1145292 - IPC Proxy for ImageAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8580205 [details] [diff] [review]
v1

>   Accessible* IdToAccessible(const uint64_t& aID);
>   HyperTextAccessible* IdToHyperTextAccessible(const uint64_t& aID);
>+  ImageAccessible* IdToImageAccessible(const uint64_t& aID);

I think it could be const, and is there some reason we haven't been making these private?

>+
>+  prio(high) sync ImagePosition(uint64_t aID, uint32_t aCoordType) returns (nsIntPoint aRetVal);
>+  prio(high) sync ImageSize(uint64_t aID) returns (nsIntSize aRetVal);

some reason you changed to returns (... ? I don't care just curious

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Oh, the space before (. That is just a mistake.


IdtoFoo would be yes private and const

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Looks like MOZ_OVERRIDE -> override causes some merging problems.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v3 (v2 + MOZ_OVERRIDE -> override)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff253e22f9b

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ff253e22f9b