Closed Bug 1145292 Opened 5 years ago Closed 5 years ago

IPC Proxy for ImageAccessible

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(3 files)

Attached patch v1Splinter Review
No description provided.
Attachment #8580205 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8580205 [details] [diff] [review]
v1

>   Accessible* IdToAccessible(const uint64_t& aID);
>   HyperTextAccessible* IdToHyperTextAccessible(const uint64_t& aID);
>+  ImageAccessible* IdToImageAccessible(const uint64_t& aID);

I think it could be const, and is there some reason we haven't been making these private?

>+
>+  prio(high) sync ImagePosition(uint64_t aID, uint32_t aCoordType) returns (nsIntPoint aRetVal);
>+  prio(high) sync ImageSize(uint64_t aID) returns (nsIntSize aRetVal);

some reason you changed to returns (... ? I don't care just curious
Attachment #8580205 - Flags: review?(tbsaunde+mozbugs) → review+
Oh, the space before (. That is just a mistake.


IdtoFoo would be yes private and const
Attached patch v2Splinter Review
Keywords: checkin-needed
Looks like MOZ_OVERRIDE -> override causes some merging problems.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ff253e22f9b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.