1145299 - [Settings][Call Barring] Entering the wrong current passcode when changing the Call Barring passcode will not fail until after the user has input a new passcode.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-call-barring-change-passcode.txt

Description:
When the user attempts to change their Call Barring passcode, they are not informed if they input the wrong current passcode until after they have finished filling out the intended new passcode.  The user will expect to be informed their passcode is wrong immediately after submitting it.

Repro Steps:
1) Update a Flame to 20150319010201
2) Launch the Settings app and navigate to Call Settings > Call Barring
3) Select 'Change passcode'
4) Input an incorrect passcode

Actual:
The user is immediately presented with the 'New passcode' screen, and are not informed they used the wrong passcode until after they attempt to submit the new one.

Expected:
The user is informed they used the wrong passcode before they input the new passcode.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150319010201
Gaia: c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gecko: cf1060d8ce9f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: video clip (URL), logcat

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2.
The user is presented with the 'New passcode' screen, and are not informed they used the wrong passcode until after they attempt to submit the new one.

Environmental Variables:
Device: Flame 2.2(319MB)(Full Flash)
Build ID: 20150318002504
Gaia: 306772a58335ac4cad285d27c3805090a8cc6886
Gecko: a6f5f4035ea5
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

------------------------

This issue does NOT occur on Flame 2.1.
The Call Barring feature is not implemented in this branch.

Comment 2

[Gerry Chang [:gchang]]

Hi Arthur,
This might need your help to investigate.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

IIUIC the `changeCallBarringPassword` API requires both the current passcode and the new passcode at the same time, so it is not possible to validate the current passcode first.

Hsinyi, can you help confirm this behavior?

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Arthur Chen [:arthurcc] from comment #3)
> IIUIC the `changeCallBarringPassword` API requires both the current passcode
> and the new passcode at the same time, so it is not possible to validate the
> current passcode first.
> 
> Hsinyi, can you help confirm this behavior?

The API behaviour is as Arthur mentioned.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Resolve as WONTFIX per comment 4.