perfherder should support y-axis zooming

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: jmaher, Assigned: mishravikas)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
jmaher
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
we just recently got x-axis zooming!  This is great.  The majority of the time in graph server y-axis zooming is just as important (especially in combination with x-axis).
(Assignee)

Updated

4 years ago
Assignee: nobody → vikasmishra95
(Assignee)

Comment 1

4 years ago
Created attachment 8580695 [details] [review]
Github PR
Attachment #8580695 - Flags: review?(wlachance)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8580695 [details] [review]
Github PR

reviewed on github, this looks good to me.
Attachment #8580695 - Flags: review+
(Reporter)

Comment 3

4 years ago
Comment on attachment 8580695 [details] [review]
Github PR

wlach, I am going to merge the pull request, I have looked over the file again- do speak up if you have concerns though.
Attachment #8580695 - Flags: review?(wlachance)

Comment 4

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/88d5aad69ab131d5e483b5b6dc714ba0e9eda9f8
Bug 1145311 - Support y-axis zoomng in perfherder

https://github.com/mozilla/treeherder-ui/commit/54d82a0a717a1cb1760346262dfeea7a66f46bbb
Merge pull request #431 from mishravikas/bug_1145311

Bug 1145311 - Support y-axis zoomng in perfherder
Yes, this all looks fine. Thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.