Closed Bug 1145375 Opened 5 years ago Closed 5 years ago

Don't kill the debugger if the user Ctrl-C's as running a mochitest

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

This is extremely bad with rr, since it'll corrupt the trace that rr is saving.
Ah, so that is what is causing my replays to hang sometimes.
(In reply to Cameron McCormack (:heycam) from comment #1)
> Ah, so that is what is causing my replays to hang sometimes.

Exactly.  :-)
Attachment #8580316 - Flags: review?(ted) → review+
Keywords: checkin-needed
I think sewardj was inquiring about this re: valgrind recently as well.
I can't say I remember that.  I did enquire about something else, to do with 
--debugger-args not overriding what the mach scripts hardwire, but AFAICS
that's unrelated.
https://hg.mozilla.org/mozilla-central/rev/43cc09835a11
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.