Closed Bug 1145395 Opened 8 years ago Closed 8 years ago

Various cleanup

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(9 files, 1 obsolete file)

39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
39 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details
No description provided.
Attached file MozReview Request: bz://1145395/Ms2ger (obsolete) —
/r/5743 - Bug 1145395 - Make some cosmetic improvements to nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan
/r/5745 - Bug 1145395 - Return a DocumentFragment from nsHTMLEditor::ParseFragment; r=ehsan
/r/5747 - Bug 1145395 - Use the local fragment variable rather than *outFragNode; r=ehsan
/r/5749 - Bug 1145395 - Pass nsIContent& to nsHTMLEditor::StripFormattingNodes; r=ehsan
/r/5751 - Bug 1145395 - Pass nsINode& to RemoveBodyAndHead in nsHTMLDataTransfer; r=ehsan
/r/5753 - Bug 1145395 - Call nsINode::Length directly in nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan
/r/5755 - Bug 1145395 - Introduce an overload of nsHTMLEditor::SelElementPosition that takes an Element; r=ehsan
/r/5757 - Bug 1145395 - Pass Element& to nsHTMLEditor::RemoveElementIfNoStyleOrIdOrClass; r=ehsan
/r/5759 - Bug 1145395 - Introduce an overload of nsHTMLEditor::RemoveStyleInside that takes nsIContent&; r=ehsan

Pull down these commits:

hg pull review -r 049fa1d971b838e5889338c162f583df2d825685
Attachment #8580336 - Flags: review?(ehsan)
I may not get around to review this for the next couple of weeks or so.  Is that OK?  If you need a faster review, I can try my best to expedite...
The code has barely changed in the months that this has been sitting in my queue, so no hurry.
Again sorry for the horrible delay.  I'm planning to get to this next week at the latest.
https://reviewboard.mozilla.org/r/5749/#review7275

Ship It!

::: editor/libeditor/nsHTMLDataTransfer.cpp:810
(Diff revision 1)
> +        return rv.ErrorCode();

You may want to use StealNSResult here.
Comment on attachment 8580336 [details]
MozReview Request: bz://1145395/Ms2ger

https://reviewboard.mozilla.org/r/5741/#review7287

Ship It!
Attachment #8580336 - Flags: review?(ehsan) → review+
Thanks for the patches, and so sorry for the extremely long delay.
Attachment #8580336 - Attachment is obsolete: true
Attachment #8619819 - Flags: review+
Attachment #8619820 - Flags: review+
Attachment #8619821 - Flags: review+
Attachment #8619822 - Flags: review+
Attachment #8619823 - Flags: review+
Attachment #8619824 - Flags: review+
Attachment #8619825 - Flags: review+
Attachment #8619826 - Flags: review+
Attachment #8619827 - Flags: review+
You need to log in before you can comment on or make changes to this bug.