1145395 - Various cleanup

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: bz://1145395/Ms2ger

/r/5743 - Bug 1145395 - Make some cosmetic improvements to nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan
/r/5745 - Bug 1145395 - Return a DocumentFragment from nsHTMLEditor::ParseFragment; r=ehsan
/r/5747 - Bug 1145395 - Use the local fragment variable rather than *outFragNode; r=ehsan
/r/5749 - Bug 1145395 - Pass nsIContent& to nsHTMLEditor::StripFormattingNodes; r=ehsan
/r/5751 - Bug 1145395 - Pass nsINode& to RemoveBodyAndHead in nsHTMLDataTransfer; r=ehsan
/r/5753 - Bug 1145395 - Call nsINode::Length directly in nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan
/r/5755 - Bug 1145395 - Introduce an overload of nsHTMLEditor::SelElementPosition that takes an Element; r=ehsan
/r/5757 - Bug 1145395 - Pass Element& to nsHTMLEditor::RemoveElementIfNoStyleOrIdOrClass; r=ehsan
/r/5759 - Bug 1145395 - Introduce an overload of nsHTMLEditor::RemoveStyleInside that takes nsIContent&; r=ehsan

Pull down these commits:

hg pull review -r 049fa1d971b838e5889338c162f583df2d825685

Comment 2

[(no longer active)]

I may not get around to review this for the next couple of weeks or so.  Is that OK?  If you need a faster review, I can try my best to expedite...

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The code has barely changed in the months that this has been sitting in my queue, so no hurry.

Comment 4

[(no longer active)]

Again sorry for the horrible delay.  I'm planning to get to this next week at the latest.

Comment 5

[(no longer active)]

https://reviewboard.mozilla.org/r/5743/#review7267

Comment 6

[(no longer active)]

https://reviewboard.mozilla.org/r/5745/#review7269

Ship It!

Comment 7

[(no longer active)]

https://reviewboard.mozilla.org/r/5747/#review7273

Ship It!

Comment 8

[(no longer active)]

https://reviewboard.mozilla.org/r/5749/#review7275

Ship It!

::: editor/libeditor/nsHTMLDataTransfer.cpp:810
(Diff revision 1)
> +        return rv.ErrorCode();

You may want to use StealNSResult here.

Comment 9

[(no longer active)]

https://reviewboard.mozilla.org/r/5751/#review7277

Ship It!

Comment 10

[(no longer active)]

https://reviewboard.mozilla.org/r/5753/#review7279

Ship It!

Comment 11

[(no longer active)]

https://reviewboard.mozilla.org/r/5755/#review7281

Ship It!

Comment 12

[(no longer active)]

https://reviewboard.mozilla.org/r/5757/#review7283

Ship It!

Comment 13

[(no longer active)]

https://reviewboard.mozilla.org/r/5759/#review7285

Ship It!

Comment 14

[(no longer active)]

Comment on attachment 8580336 [details]
MozReview Request: bz://1145395/Ms2ger

https://reviewboard.mozilla.org/r/5741/#review7287

Ship It!

Comment 15

[(no longer active)]

Thanks for the patches, and so sorry for the extremely long delay.

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84b2aaa4b3ce
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cb329c684fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/a67dc8d13f73
https://hg.mozilla.org/integration/mozilla-inbound/rev/701fb6cf3274
https://hg.mozilla.org/integration/mozilla-inbound/rev/6774b72255d4
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb200c2f02b
https://hg.mozilla.org/integration/mozilla-inbound/rev/704489378ffe
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b7d858b2de9
https://hg.mozilla.org/integration/mozilla-inbound/rev/76a8ad972f7d

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/84b2aaa4b3ce
https://hg.mozilla.org/mozilla-central/rev/5cb329c684fb
https://hg.mozilla.org/mozilla-central/rev/a67dc8d13f73
https://hg.mozilla.org/mozilla-central/rev/701fb6cf3274
https://hg.mozilla.org/mozilla-central/rev/6774b72255d4
https://hg.mozilla.org/mozilla-central/rev/adb200c2f02b
https://hg.mozilla.org/mozilla-central/rev/704489378ffe
https://hg.mozilla.org/mozilla-central/rev/5b7d858b2de9
https://hg.mozilla.org/mozilla-central/rev/76a8ad972f7d

Comment 19

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Make some cosmetic improvements to nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Return a DocumentFragment from nsHTMLEditor::ParseFragment; r=ehsan

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Use the local fragment variable rather than *outFragNode; r=ehsan

Comment 22

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Pass nsIContent& to nsHTMLEditor::StripFormattingNodes; r=ehsan

Comment 23

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Pass nsINode& to RemoveBodyAndHead in nsHTMLDataTransfer; r=ehsan

Comment 24

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Call nsINode::Length directly in nsHTMLEditor::CreateDOMFragmentFromPaste; r=ehsan

Comment 25

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Introduce an overload of nsHTMLEditor::SelElementPosition that takes an Element; r=ehsan

Comment 26

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Pass Element& to nsHTMLEditor::RemoveElementIfNoStyleOrIdOrClass; r=ehsan

Comment 27

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: MozReview Request: Bug 1145395 - Introduce an overload of nsHTMLEditor::RemoveStyleInside that takes nsIContent&; r=ehsan