MediaManager opened on shutdown.

RESOLVED FIXED in Firefox 39

Status

()

Core
WebRTC: Audio/Video
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jib, Assigned: jib)

Tracking

38 Branch
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Turns out that if MediaManager has gone unused - which in the chrome process is all the time now -  then it gets created for the first time on shutdown:

MediaManager::Get() {
  if (!sSingleton) {
    NS_ASSERTION(NS_IsMainThread(), "Only create MediaManager on main thread");

=>  sSingleton = new MediaManager();

> #0	0x00000001043948a0 in mozilla::MediaManager::Get() at /Users/Jan/moz/mozilla-central/dom/media/MediaManager.cpp:1422
> #1	0x0000000102ecc23b in mozilla::dom::Navigator::OnNavigation() at /Users/Jan/moz/mozilla-central/dom/base/Navigator.cpp:1986
> #2	0x0000000102d9b386 in nsGlobalWindow::FreeInnerObjects() at /Users/Jan/moz/mozilla-central/dom/base/nsGlobalWindow.cpp:1604
> #3	0x0000000102da3737 in nsGlobalWindow::DetachFromDocShell() at /Users/Jan/moz/mozilla-central/dom/base/nsGlobalWindow.cpp:2893
> #4	0x00000001058790d9 in nsDocShell::Destroy() at /Users/Jan/moz/mozilla-central/docshell/base/nsDocShell.cpp:5792
> #5	0x000000010589976c in non-virtual thunk to nsDocShell::Destroy() at /Users/Jan/moz/mozilla-central/docshell/base/nsDocShell.cpp:5827
> #6	0x00000001059658ed in nsXULWindow::Destroy() at /Users/Jan/moz/mozilla-central/xpfe/appshell/nsXULWindow.cpp:476
> #7	0x000000010594e3bb in nsWebShellWindow::Destroy() at /Users/Jan/moz/mozilla-central/xpfe/appshell/nsWebShellWindow.cpp:758
> #8	0x00000001059617c1 in nsWebShellWindow::RequestWindowClose(nsIWidget*) at /Users/Jan/moz/mozilla-central/xpfe/appshell/nsWebShellWindow.cpp:305
> #9	0x000000010596187f in non-virtual thunk to nsWebShellWindow::RequestWindowClose(nsIWidget*) at /Users/Jan/moz/mozilla-central/xpfe/appshell/nsWebShellWindow.cpp:307
> #10	0x0000000104d855ec in -[WindowDelegate windowShouldClose:] at /Users/Jan/moz/mozilla-central/widget/cocoa/nsCocoaWindow.mm:2422
> #11	0x00007fff8de2df44 in __19-[NSWindow __close]_block_invoke ()
> #12	0x00007fff8de2de79 in -[NSWindow __close] ()
> #13	0x00007fff8de2dd55 in -[NSWindow _close:] ()
> #14	0x00007fff8dde1260 in -[NSApplication sendAction:to:from:] ()
> #15	0x00007fff8dde10de in -[NSControl sendAction:to:] ()
> #16	0x00007fff8de2dc4d in -[NSCell _sendActionFrom:] ()
> #17	0x00007fff8de47655 in -[NSCell trackMouse:inRect:ofView:untilMouseUp:] ()
> #18	0x00007fff8de46a27 in -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] ()
> #19	0x00007fff8de4613d in -[NSControl mouseDown:] ()
> #20	0x00007fff8e2dd831 in -[_NSThemeWidget mouseDown:] ()
> #21	0x00007fff8ddc7a58 in -[NSWindow sendEvent:] ()
> #22	0x0000000104d89d0d in -[ToolbarWindow sendEvent:] at /Users/Jan/moz/mozilla-central/widget/cocoa/nsCocoaWindow.mm:3439
> #23	0x00007fff8dd665d4 in -[NSApplication sendEvent:] ()
> #24	0x0000000104d75192 in -[GeckoNSApplication sendEvent:] at /Users/Jan/moz/mozilla-central/widget/cocoa/nsAppShell.mm:107
> #25	0x00007fff8dbb69f9 in -[NSApplication run] ()
> #26	0x0000000104d770a7 in nsAppShell::Run() at /Users/Jan/moz/mozilla-central/widget/cocoa/nsAppShell.mm:651
> #27	0x0000000105c9defc in nsAppStartup::Run() at /Users/Jan/moz/mozilla-central/toolkit/components/startup/nsAppStartup.cpp:281
> #28	0x0000000105d4f7e0 in XREMain::XRE_mainRun() at /Users/Jan/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:4202
> #29	0x0000000105d5008e in XREMain::XRE_main(int, char**, nsXREAppData const*) at /Users/Jan/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:4278
> #30	0x0000000105d50552 in XRE_main at /Users/Jan/moz/mozilla-central/toolkit/xre/nsAppRunner.cpp:4498
> #31	0x0000000100002b9e in do_main(int, char**, nsIFile*) at /Users/Jan/moz/mozilla-central/browser/app/nsBrowserApp.cpp:294
> #32	0x0000000100001f03 in main at /Users/Jan/moz/mozilla-central/browser/app/nsBrowserApp.cpp:667
> #33	0x0000000100001964 in start ()

It shouldn't create it here since there's no need to, so this is a waste of resources.
Created attachment 8580333 [details] [diff] [review]
don't open MediaManager on shutdown
Attachment #8580333 - Flags: review?(rjesup)
Green try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a29772446c40

Updated

3 years ago
Attachment #8580333 - Flags: review?(rjesup) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b66d8f67cf7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1b66d8f67cf7
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.