Closed
Bug 1145416
Opened 9 years ago
Closed 9 years ago
IonMonkey: Add range to MFilterTypeSet
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Easy patch. Just propagate the range through the MFilterTypeSet.
Assignee: nobody → hv1989
Attachment #8580343 -
Flags: review?(nicolas.b.pierron)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8580343 [details] [diff] [review] Patch Review of attachment 8580343 [details] [diff] [review]: ----------------------------------------------------------------- I am surprised, do you have an example where this could be useful? I was expecting MFilterTypeSet to be used for filtering object types more than numbers.
Attachment #8580343 -
Flags: review?(nicolas.b.pierron) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/253bebf00e0f FilterTypeSet is mostly used for undefined/null, but not exclusive. I noticed it on a knockout benchmark to get used for numbers.
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/253bebf00e0f
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
|
||
Comment 5•9 years ago
|
||
Either this bug or bug 1143878 regressed misc-bugs-1131099-underscore on AWFY by 38%.
Flags: needinfo?(hv1989)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Given the patches: bug 1143878 is more likely.
Flags: needinfo?(hv1989)
You need to log in
before you can comment on or make changes to this bug.
Description
•