IonMonkey: Add range to MFilterTypeSet

RESOLVED FIXED in Firefox 39

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

No description provided.
Posted patch PatchSplinter Review
Easy patch. Just propagate the range through the MFilterTypeSet.
Assignee: nobody → hv1989
Attachment #8580343 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8580343 [details] [diff] [review]
Patch

Review of attachment 8580343 [details] [diff] [review]:
-----------------------------------------------------------------

I am surprised, do you have an example where this could be useful?
I was expecting MFilterTypeSet to be used for filtering object types more than numbers.
Attachment #8580343 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/253bebf00e0f

FilterTypeSet is mostly used for undefined/null, but not exclusive. I noticed it on a knockout benchmark to get used for numbers.
https://hg.mozilla.org/mozilla-central/rev/253bebf00e0f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Either this bug or bug 1143878 regressed misc-bugs-1131099-underscore on AWFY by 38%.
Flags: needinfo?(hv1989)
Given the patches: bug 1143878 is more likely.
Flags: needinfo?(hv1989)
You need to log in before you can comment on or make changes to this bug.