1145430 - Untangle DebugScopeProxy::handleUnaliasedAccess

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Waldo on DebugScopeProxy::handleUnaliasedAccess (in bug 1142794, comment 5):
> It's extraordinarily frustrating to have all accesses -- sets and gets
> both -- go through a single method.  :-( It's thus impossible to tell
> from the signature what'll happen, and what will be affected by the
> call.
> 
> We've been in this situation before -- I *remember* having one
> massive, messy function for this sort of thing before, and manually
> disentangling it into something far more readable.  It was a huge win
> for readability.  And now, we've regressed to exactly the same
> situation again.  :-(
> 
> Could you file a followup to break this method into handleUnaliasedGet
> and handleUnaliasedSet, have each of those methods delegate to get/set
> methods existing on CallObject and on ClonedBlockObject, and then pair
> up those classes' get/set methods at the source level to aid in
> comparisons of the two, with whatever prefatory code-sharing is
> possible in such system?
> 
> Once this happens, there will be no need to copy |v| here.