1145433 - Tab list always opens scrolled to the top

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Dan Callahan [:callahad]]

When I open the tab tray, it always shows me the very top of the list, even if my most recent tab was the last one. This is frustrating as I'm most likely working with my more recent tabs, which are placed at the bottom of the list. Thus, I have to scroll to the bottom every single time I open the tab list.

iOS 8.2 / Build 5 / 5th Generation iPod Touch

Comment 1

[Dan Callahan [:callahad]]

Still present in build 6

Comment 2

[Aaron Train [:aaronmt]]

We should mimic android.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's make sure the active tab is not cropped, but is fully visible

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/561

Since we were only calling layoutSubviews on the collectionView, the frame of which we used to scroll in did not account for the height of the navigation bar which caused the last tab to be cropped at the bottom when minimizing the tab. Now, all tabs should be centered vertically if there are enough tabs above and below and the last tab will not be cropped at the bottom.

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/562

Updated PR (looks like you accidentally linked to #561).

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8615608 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/562

LGTM

Comment 7

[Stephan Leroux [:sleroux]]

Thanks! Merged.