Closed Bug 1145433 Opened 6 years ago Closed 5 years ago
Tab list always opens scrolled to the top
47 bytes, text/x-github-pull-request
|Details | Review|
When I open the tab tray, it always shows me the very top of the list, even if my most recent tab was the last one. This is frustrating as I'm most likely working with my more recent tabs, which are placed at the bottom of the list. Thus, I have to scroll to the bottom every single time I open the tab list. iOS 8.2 / Build 5 / 5th Generation iPod Touch
Still present in build 6
We should mimic android.
tracking-fennec: --- → ?
Let's make sure the active tab is not cropped, but is fully visible
Since we were only calling layoutSubviews on the collectionView, the frame of which we used to scroll in did not account for the height of the navigation bar which caused the last tab to be cropped at the bottom when minimizing the tab. Now, all tabs should be centered vertically if there are enough tabs above and below and the last tab will not be cropped at the bottom.
Updated PR (looks like you accidentally linked to #561).
Comment on attachment 8615608 [details] [review] PR https://github.com/mozilla/firefox-ios/pull/562 LGTM
Attachment #8615608 - Flags: review?(sarentz) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.