1145438 - DB Crash under postgres when using alias column in buglist.cgi

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Matt Tyson]

Attachment: Group by skip

Postgres does not allow aggregates in a group by column.

When you add the alias column to your list of columns in buglist.cgi, it will crash with the following:

DBD::Pg::db selectall_arrayref failed: ERROR:  aggregate functions are not allowed in GROUP BY
LINE 17: ...,map_component.name,bugs.short_desc,bugs.delta_ts,STRING_AGG...

Attached is a patch to add alias to the GROUP_BY_SKIP constant in Bugzilla/Search.pm

Tested on postgres 9.3 with trunk code.

Comment 1

[:glob ✱]

Comment on attachment 8580377 [details] [diff] [review]
Group by skip

Review of attachment 8580377 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 2

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   5c8594a..377de9b  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   f5fb20f..5813ef5  5.0 -> 5.0

Comment 3

[Frédéric Buclin]

Comment on attachment 8580377 [details] [diff] [review]
Group by skip

use constant GROUP_BY_SKIP => qw(
>     longdescs.count
>     percentage_complete
>     tag
>+    alias
> );

Could you keep this list sorted alphabetically, please? :(

Comment 4

[Matt Tyson]

Attachment: Fix the ordering

Oops, sorry about messing up the ordering.  This should fix it.

Comment 5

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   4aa1485..7559020  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   485ad42..516f99e  5.0 -> 5.0