1145472 - browser_no_tabs.js loads a chrome URL from the hidden window (resource:// outside OS X)

Status: RESOLVED FIXED

(Firefox :: Tours, defect)

Description

[Matthew N. [:MattN]]

If you backout the workaround in https://hg.mozilla.org/integration/mozilla-inbound/rev/8428dce9dde0 you will see the following error:

Security Error: Content at resource://gre-resources/hiddenWindow.html may not load or link to chrome://global/content/mozilla.xhtml

The workaround was put in as a temporary measure and should be removed.

Dexter, are you able to fix this test to not cause the error?

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: HiddenFrame attempt

I was not able to reproduce the problem on OSX 10.8.5 after backing out the change.

This patch changes the test to use HiddenFrame, which does not set the "src" field of the IFRAME to the offending URL. Does this fix the issue?

Comment 2

[Matthew N. [:MattN]]

(In reply to Alessio Placitelli [:Dexter] from comment #1)
> Created attachment 8580742 [details] [diff] [review]
> HiddenFrame attempt
> 
> I was not able to reproduce the problem on OSX 10.8.5 after backing out the
> change.

This is a problem outside of OS X (that was what I meant by "outside OS X" in the summary) since the hidden window on OS X has a chrome URI instead of a resource one.

> This patch changes the test to use HiddenFrame, which does not set the "src"
> field of the IFRAME to the offending URL. Does this fix the issue?

Can you test on Windows or Linux and flag me for review if it works?

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8580742 [details] [diff] [review]
HiddenFrame attempt

Whoops, sorry. I've checked on Windows and this patch fixes the problem there. I'll double check on Linux in the following days.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8580742 [details] [diff] [review]
HiddenFrame attempt

Review of attachment 8580742 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming this test no longer fails on try with the hidden window whitelist removed.

Comment 5

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17d867e04dd9

Comment 6

[Alessio Placitelli [:Dexter]]

(In reply to Matthew N. [:MattN] from comment #4)
> r=me assuming this test no longer fails on try with the hidden window
> whitelist removed.

It seems to work as the test, which is in the bc2 suite, is consistently green across all the platforms.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/94fd0d06da83

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/94fd0d06da83