Alter factory pattern in record generation to avoid type inference bug

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
This was pretty painful when I found it. Comments include details. Radar 20230159.
(Assignee)

Comment 1

3 years ago
Created attachment 8580487 [details] [review]
Pull req.
Attachment #8580487 - Flags: review?(nalexander)
Comment on attachment 8580487 [details] [review]
Pull req.

Looks great, and great comments.
Attachment #8580487 - Flags: review?(nalexander) → review+
(Assignee)

Comment 3

3 years ago
https://github.com/mozilla/firefox-ios/commit/fa835ead475e05ed07c53cecc80e79702bb28d8e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Component: General → General
Product: Firefox for Android → Firefox for iOS
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.