1145522 - Theme switcher panel and Show/hide menus in customization mode are mispositioned

Status: RESOLVED DUPLICATE of bug 1145868

(Firefox :: Toolbars and Customization, defect)

Description

[u428464]

Since a few days on Nightly the theme switcher panel in customization mode doesn't anchor to the button anymore but far above. Same for the show/hide menu that appears in the middle of the screen.

Comment 1

[:Gijs (he/him)]

Sounds like it's caused by bug 1143974. :tn?

Comment 2

[Loic]

[Tracking Requested - why for this release]:

Regression range:
good=2015-03-15
bad=2015-03-16
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af68c9c0e903&tochange=436686833af0

suspected: 
Timothy Nikkel — Bug 1130400. Part 1. Pass the passed in anchor frame to SetPopupPosition in nsMenuPopupFrame::LayoutPopup if we have one. r=enndeakin

Comment 4

[Timothy Nikkel (:tnikkel)]

I'll investigate. If I can't fix it shortly I'll back out.

Comment 5

[Timothy Nikkel (:tnikkel)]

Hmm, so my local bisection blames https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=6cd4d71818ee

However applying part 2 of bug 1130400 fixes the bug for me. This does make sense since a change on reflow of flex items could determine if the condition of bug 1130400 comes up or not.

Part 2 of bug 1130400 is already on inbound, so this bug should get fixed when that merges.

Comment 6

[Loic]

(In reply to Timothy Nikkel (:tn) from comment #5)
> Hmm, so my local bisection blames
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?changeset=6cd4d71818ee


It was a speculative guess of mine, so maybe I was wrong.

Comment 7

[Alice0775 White]

Sorry dupe