1145543 - [RTL][Contacts]The alphabet picker is located on the left side of Gmail, Outlook and Facebook contacts list view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_Contact list.png

[1.Description]:
[RTL][v2.2&v3.0][Contacts]Sign in Gmail, Outlook and Facebook accounts in Contacts app, the alphabet picker is located on the left side of contacts list view.
See attachment:Screenshot_Contact list.png

[2.Testing Steps]: 
1.Launch Contacts.
2.Enter Settings view.
3.Import contacts from Gmail, Outlook and Facebook.
4.Sign in Gmail, Outlook and Facebook accounts.
5.Observe the contact list.

[3.Expected Result]: 
5.The alphabet picker should be located on the right side of contacts list view.

[4.Actual Result]: 
5.The alphabet picker is located on the left side of contacts list view.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150319160212
Gaia Revision          c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gaia Date              2015-03-18 19:30:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cbd0efcd976c
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.193329
Firmware Date          Thu Mar 19 19:33:42 EDT 2015
Bootloader             L1TC000118D0
[6.Reproduction Frequency]: 
Always Recurrence,10/10

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Correct, the alphabet picker should be on the right side, as in Bug 1135927
Nominating to ensure consistency across Contacts app

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issue on RTL

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

This is a blocking bug, we are 1 week away from FC, and no one has been assigned to this yet.
Can we please have someone from Contacts team take this? Julien maybe you can help with getting the word out please? I've reached out to EM but no reply yet - must be busy
thanks! :)

Comment 4

[Julien Wajsberg [:julienw]]

This is weird, given the screenshots in bug 1135927, that this works like this.

This is more a question to Francisco.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Hi Julien, you mean the alphabet is on the left?

That's correct, should be on the right, that means not mirroring LTR behaviour. Right now in the normal list we have it working correctly, this is for the list that appears when you import from gmail, live, etc.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1145543 > mozilla-b2g:master

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8586385 [details] [review]
[gaia] arcturus:bug-1145543 > mozilla-b2g:master

Finally went through the quick and dirty solution that is having the specific rules for the import page.

Ideally, I would like to have a single list component, shareable under all apps that need a contact list (with a specific source), but we don't have time for that :(

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a4fc366bc92462f008dea2a1b0ae2f6f039ae10a

Comment 9

[Lancy(Leave from Mozilla)]

Attachment: Verify1_Flame3.0_Pass.png

According to the comment 0, this issue has been verified pass on latest Flame 3.0 build.
See attachment:Verify1_Flame3.0_Pass.png
Reproducing rate:0/10

Flame 3.0 build (Unaffected):
Build ID               20150402160202
Gaia Revision          62042ffcc8c6cca0f51ad23f5c2b979fc153b5a7
Gaia Date              2015-04-02 16:01:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/513265a4cbc2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.192125
Firmware Date          Thu Apr  2 19:21:37 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this patch for Gaia v2.2 approval when you get a chance.

Comment 11

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15413/

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8586385 [details] [review]
[gaia] arcturus:bug-1145543 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
RTL
[User impact] if declined:
Bad user experience
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
Low
[String changes made]:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ea0b2a0a19318bde0c61f9a37d5244f21f01e3d0

Comment 14

[Sue]

Attachment: v2.2_pass.png

This issue has been verified passed on latest build of Flame 2.2 with the same steps in comment 0.
See attachment:v2.2_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201515
Firmware Date          Tue Apr 14 20:15:24 EDT 2015
Bootloader             L1TC000118D0