1145551 - DTMF should be sent using the active SIM, the given or the default one (in that order)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Norry.L.F(Leave from Mozilla)]

Attachment: 10000.mp4

[1.Description]:
[Flame v2.2 & v3.0][Contacts]Extension will not be sent if user select a non default SIM.
Found time:17:29
Attachment:logcat_1729 & 10000.MP4

[2.Testing Steps]: 
Prerequisite:Device with 2 SIM cards.
1. Save a number in Contacts as "10000,,,1".
2. Open contact details. 
3. Long tap on Dial to choose non default SIM. 

[3.Expected Result]: 
3.Outgoing call made, extension sent without user interaction after a longer pause. 

[4.Actual Result]: 
3.Outgoing call made, but extension not be sent.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150319160212
Gaia Revision          c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gaia Date              2015-03-18 19:30:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cbd0efcd976c
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.193329
Firmware Date          Thu Mar 19 19:33:42 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15691

[8.Note]:
Also exist on dialer

Comment 1

[Norry.L.F(Leave from Mozilla)]

Attachment: logcat_1729.txt

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Broken feature planned for 2.2.

QA wanted to get a logcat with RIL debugging enabled[1]

[1] https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#RIL_Debugging

Comment 3

[Brogan Zumwalt [Inactive]]

Unable to get contact with an extension to work at all regardless of SIM that used. Created a contact "6509030800,,,92" and the extension is never sent when I initiate call through contacts no matter if I use SIM 1 or SIM 2. Want to make sure I am not missing a step here.


Device: Flame 3.0
Build ID: 20150320010204
Gaia: 8837f94418d69a0b06c1f4843b0779e2bb72165a
Gecko: 4d2d97b3ba34
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 4

[Johan Lorenzo [:jlorenzo]]

I repro the issue with the SIM1 on yesterday's 2.2 build[1]. Beatriz, can you confirm this is a regression?

[1] Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Comment 5

[Shally Li（leave from Mozilla）]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #2)
> [Blocking Requested - why for this release]: Broken feature planned for 2.2.
> 
> QA wanted to get a logcat with RIL debugging enabled[1]
> 
> [1] https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#RIL_Debugging

Hi Johan,

Update the logcat (new_logcat_v2.2_1538.txt) with RIL debugging enabled[1].

Comment 6

[Shally Li（leave from Mozilla）]

Attachment: new_logcat_v2.2_1553.txt

Please see "new_logcat_v2.2_1553.txt". 
Please ignore "new_logcat_v2.2_1538.txt".Thanks.

Comment 7

[Beatriz Rodríguez [:brg]]

I have tested with Flame:
*Today 2.2 build(Gecko-c36e800.Gaia-44c6206)
*20th January build v2.2 (Gecko-bb6c4d3.Gaia-f5b3d1b)

With the same result described in this bug:

When the call is done through the SIM card that it is not active by default, the pause (extensions) are not done while it is working very well in the default SIM card.

I am not sure if this functionality was covered by the first implementation of the dial pause feature. I dont think so. German could you please confirm?

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! Sadly I think we did not cover the mentioned use case in the current implementation and probably the comma separated part is being lost (probably sanitised) somewhere :(

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: major issue on new feature. currently it's an inconsistent behavior

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

This might be a RIL issues. I can see this entry in the log when trying to send a DTMF with a non default SIM:

2771 Gecko  I  RIL Worker: [0] Handling parcel as REQUEST_DTMF_START
2771 Gecko  I  -*- RadioInterface[0]: Received message from worker: {"dtmfChar":"7","rilMessageClientId":0,"rilMessageToken":64,"rilMessageType":"startTone","rilRequestType":49,"rilRequestError":2,"errorMsg":"GenericFailure","success":false}

Comment 11

[GitHub Autolander Bot]

Attachment: Gaia fix

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Gecko fix

Hsin-Yi, while we can fix this issue on Gaia only by giving the appropriate service ID to Telephony::SendTone, I also think that we need to fix this in the platform by selecting the active service ID instead of the default one if there is a call in place. If you think that this approach is ok, I'll write some tests for it. Thanks in advance for your feedback!

Comment 13

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8583087 [details] [review]
Gaia fix

Looks good.

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

Thank you Doug!

Comment 15

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#wf143K9CRRi-Yly0V0GOZg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 16

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8583091 [details] [diff] [review]
Gecko fix

Review of attachment 8583091 [details] [diff] [review]:
-----------------------------------------------------------------

This does make sense to me. Thank you!

Just a note that we will encounter some issues in DSDA if gaia doesn't apply the serviceId, but for DSDS that's fine.

Comment 17

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7c5fdf13155b61c6ed342f0a60949081ddf493de

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 approval on this patch when you get a chance.

Comment 19

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8583087 [details] [review]
Gaia fix

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Dialer/RIL
[User impact] if declined: The user won't be able to send dial tones while with a non-default SIM card.
[Testing completed]: Manual tests. Unit test added.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 20

[Fernando Jiménez Moreno [:ferjm]]

I filed bug 1148036 for the platform change.

Comment 21

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v3.0. 

Actual result: Device enters outgoing call made, and DTMF is sent using the active SIM1/SIM2.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/5

Device: Flame 3.0 build(Pass)
Build ID               20150327160203
Gaia Revision          9cc496cecc37d7a29f9279827cdf6e4891211f67
Gaia Date              2015-03-27 13:55:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/44e454b5e93b
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150327.192632
Firmware Date          Fri Mar 27 19:26:42 EDT 2015
Bootloader             L1TC000118D0

Comment 22

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9b160617bd0b2f20de5cb496c67bfea5cf5c1739

Comment 24

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Nightly Flame v2.2. 

Actual result: Device enters outgoing call made, and DTMF is sent using the active SIM1/SIM2.
Reproduce rate: 0/5

Device: Flame 2.2 build(Pass)
Build ID               20150401002624
Gaia Revision          8b3086ad3963f1707e2bee9094baccafffe161c4
Gaia Date              2015-03-31 21:48:06
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20b67213a047
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150401.042225
Firmware Date          Wed Apr  1 04:22:36 EDT 2015
Bootloader             L1TC000118D0

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84908721cf9e