1145616 - Test failure 'notification is undefined' in testPreferencesMasterPassword.js and testPasswordSavedAndDeleted.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have a new regression in our test for todays Nightly build. Looks like a change in the password manager code causes us to fail with this failure:

ERROR | Test Failure | {
  "exception": {
    "message": "notification is undefined", 
    "lineNumber": 912, 
    "name": "TypeError", 
    "fileName": "resource://mozmill/stdlib/securable-module.js -> file:///home/mozauto/jenkins/workspace/mozilla-central_functional/data/mozmill-tests/firefox/lib/toolbars.js"
  }

Maybe they renamed the id of the notification or such. Should be easy to find out.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Pushlog for Nightly builds between March 19th and March 20th:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cf1060d8ce9f&tochange=4d2d97b3ba34

Bug 1143852 seems to be the regressor here. Looks like it can be fixed quickly. I will try. Otherwise we have to skip those tests forever.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A fix is upcoming.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Fix id of password notification

This is the bustage fix for our tests.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on default:

https://hg.mozilla.org/qa/mozmill-tests/rev/9c4363786ee3