bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

[operator shelf] change TEF desktop rendering

VERIFIED FIXED in 2015-03-24

Status

Marketplace
Consumer Pages
P1
trivial
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: ddurst, Assigned: spasovski)

Tracking

2015-03-24
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

3 years ago
The operator shelf (for TEF especially) doesn't play well with their image on desktop.

Let's do this:
- remove the curve entirely on desktop (so their set color will be 100% opacity)
- adjust the width of the [data-feed-landing-has-background-image] .feed-landing-description to be max 320px (parity with the image <-- this has a problem with a lot of description text that (so far) no one is using. With 300 character limit, that's a LOT of possible text)
- adjust the vertical spacing of the h1 next to the image so it's centered nicely if there is a .feed-landing-description as well as if there isn't

Mobile should NOT change; mobile is fine.

I know this is an outlier, and if it's easier to do this for all shelves, so be it.

I'm NI Philip, because this may force us to go with a stacked layout.

Aiming to cherry-pick this for next tuesday. Setting milestone.

Comment 1

3 years ago
Everything here sounds great, but let's reduce char count to 200.
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Verified in FF39(Win7) in marketplace-dev.allizom.org

In the images provided in https://github.com/mozilla/fireplace/pull/1094 I can see that when there is no description the image is centered. On marketplace either if there is a description or not the image is aligned in the same way:
no description: http://screencast.com/t/MM0ZtkmK
description: http://screencast.com/t/2UOZHdqxeNmo

Is this now intended?
Flags: needinfo?(dspasovski)
(Assignee)

Comment 4

3 years ago
Yes. I should've updated the screenshots in the github PR but it's better if they are consistent and not necessarily centered - this is related to the right column's parent container size.
Flags: needinfo?(dspasovski)

Comment 5

3 years ago
Thanks for the response.
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.