1145655 - Remove remnants of Browser Debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

Once upon a time in a land far far away, there was a Browser Debugger in devtools. Seasons came and seasons went and the Browser Debugger grew up to become the Browser Toolbox. The Browser Debugger had debugger.xul as the sole document in the window and updated the window title in debugger-panes.js:_onSourceSelect. Still to this day browser.properties contains the remains of that era, the strings DebuggerWindowTitle and DebuggerWindowScriptTitle.

Since the Browser Toolbox window contains the toolbox.xul document with debugger.xul as an iframe, the Old Strings can no longer be seen and are forever cursed to live in the catacombs of the Code Repository. The entire world craves for a valiant knight in his white horse who will slay these dragons and liberate the debugger source from the iron grip of The Ancients, once and for all.

May you, gentle prince, be the one they are waiting for?

Comment 1

[Dalimil Hajek [:dalimil]]

I would like to work on this. Can someone assign this to me?

Comment 2

[Dalimil Hajek [:dalimil]]

Attachment: rev1

I removed the strings, although I wasn't 100% it is safe to remove the code setting the document.title in sources-view.js and debugger-view.js

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8762591 [details] [diff] [review]
rev1

Review of attachment 8762591 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me!  Sorry for the delay, all of Mozilla is away at a meeting this week.

Could you update the commit message to say the reviewer as "r=jryans" instead?

Once you post the updated patch, I can send it to our try server for testing.

Comment 4

[Dalimil Hajek [:dalimil]]

Attachment: rev2

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8763039 [details] [diff] [review]
rev2

Review of attachment 8763039 [details] [diff] [review]:
-----------------------------------------------------------------

Great, sorry again for the delay.  Thanks for working on this!

I'll submit this to the try server now.  Assuming the results look good, you can add "checkin-needed" to the keywords field of the bug.  (I gave your account access to do so.)

Please check out http://firefox-dev.tools for other bugs you may be interested in.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b1e4644fb4d

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

From the try failures, it looks like we also need to update the test devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-01.js, which was checking the title.

You can run the test locally with:

./mach mochitest devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-01.js

Could you take a look at this?

Comment 8

[Dalimil Hajek [:dalimil]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #7)
> From the try failures, it looks like we also need to update the test
> devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-01.js,
> which was checking the title.
> 
> You can run the test locally with:
> 
> ./mach mochitest
> devtools/client/debugger/test/mochitest/browser_dbg_scripts-switching-01.js
> 
> Could you take a look at this?

Yes, I'll take a look at it in the next few days.

Comment 9

[Dalimil Hajek [:dalimil]]

Attachment: rev3

Ok, I fixed it.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8765109 [details] [diff] [review]
rev3

Review of attachment 8765109 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, let's see what try thinks:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=875f3f4ea510

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Great, the try run looks good.  One of the sheriffs will land this to fx-team soon, and then merge it to mozilla-central a day later.  The bug will be marked resolved once it merges.

Thanks for working on this!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/4535711555f7
Remove remnants of Browser Debugger. r=jryans

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4535711555f7