1145702 - MOZ_ASSERT((result.value * mFirstOverscrollAnimationSample.value) >= 0.0f) is still firing

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

I fixed the problem I thought was causing this assertion to fire in bug 1131749, but it looks like it's still firing (see bug 1131749 comment 16).

Comment 1

[Botond Ballo [:botond]]

Attachment: MozReview Request: bz://1145702/botond

/r/5795 - Bug 1145702 - Make the assertion in Axis::GetOverscroll() more informative. r=Cwiiis

Pull down this commit:

hg pull review -r 6f7ec14934ec9c479ed1543abcba9b525acc2be3

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8580788 [details]
MozReview Request: bz://1145702/botond

Carrying r=Cwiiis from bug 1131749 comment 21.

Comment 3

[Botond Ballo [:botond]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d528257356

Comment 4

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #3)
> Try push:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d528257356

Canceled this one and included this a combined try push with another patch to save some resources:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a45913b4e313

Comment 5

[Botond Ballo [:botond]]

And the assertion just fired for me while using the Browser app:

###!!! ASSERTION: GetOverscroll() (252.442856) and first overscroll animation sample (-691.253479) have different signs

Not rounding error!

Comment 6

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)
> And the assertion just fired for me while using the Browser app:
> 
> ###!!! ASSERTION: GetOverscroll() (252.442856) and first overscroll
> animation sample (-691.253479) have different signs
> 
> Not rounding error!

Unfortunately, I wasn't able to reproduce this again. I did look over the code again, and I can't see why we would be getting values like this :/

In any case, landed the diagnostic patch, it can't hurt:

https://hg.mozilla.org/integration/mozilla-inbound/rev/962d3b65774a

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/962d3b65774a

Comment 9

[Botond Ballo [:botond]]

Attachment: MozReview Request: Bug 1145702 - Make the assertion in Axis::GetOverscroll() more informative. r=Cwiiis