MOZ_ASSERT((result.value * mFirstOverscrollAnimationSample.value) >= 0.0f) is still firing

RESOLVED FIXED in Firefox 39

Status

()

Core
Panning and Zooming
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: botond, Assigned: botond)

Tracking

Trunk
mozilla39
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
I fixed the problem I thought was causing this assertion to fire in bug 1131749, but it looks like it's still firing (see bug 1131749 comment 16).
(Assignee)

Comment 1

3 years ago
Created attachment 8580788 [details]
MozReview Request: bz://1145702/botond

/r/5795 - Bug 1145702 - Make the assertion in Axis::GetOverscroll() more informative. r=Cwiiis

Pull down this commit:

hg pull review -r 6f7ec14934ec9c479ed1543abcba9b525acc2be3
(Assignee)

Comment 2

3 years ago
Comment on attachment 8580788 [details]
MozReview Request: bz://1145702/botond

Carrying r=Cwiiis from bug 1131749 comment 21.
Attachment #8580788 - Flags: review+
(Assignee)

Comment 3

3 years ago
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d528257356
(Assignee)

Comment 4

3 years ago
(In reply to Botond Ballo [:botond] from comment #3)
> Try push:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d528257356

Canceled this one and included this a combined try push with another patch to save some resources:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a45913b4e313
(Assignee)

Updated

3 years ago
Whiteboard: [gfx-noted]
(Assignee)

Comment 5

3 years ago
And the assertion just fired for me while using the Browser app:

###!!! ASSERTION: GetOverscroll() (252.442856) and first overscroll animation sample (-691.253479) have different signs

Not rounding error!
Keywords: checkin-needed
(Assignee)

Comment 6

3 years ago
(In reply to Botond Ballo [:botond] from comment #5)
> And the assertion just fired for me while using the Browser app:
> 
> ###!!! ASSERTION: GetOverscroll() (252.442856) and first overscroll
> animation sample (-691.253479) have different signs
> 
> Not rounding error!

Unfortunately, I wasn't able to reproduce this again. I did look over the code again, and I can't see why we would be getting values like this :/

In any case, landed the diagnostic patch, it can't hurt:

https://hg.mozilla.org/integration/mozilla-inbound/rev/962d3b65774a
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/962d3b65774a
Assignee: nobody → botond
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 8

3 years ago
Comment on attachment 8580788 [details]
MozReview Request: bz://1145702/botond
Attachment #8580788 - Attachment is obsolete: true
Attachment #8619830 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8619830 [details]
MozReview Request: Bug 1145702 - Make the assertion in Axis::GetOverscroll() more informative. r=Cwiiis
You need to log in before you can comment on or make changes to this bug.