1145734 - Remove the tabbrowser-arrowscrollbox binding in tabbrowser.css so that we consistently use clicktoscroll to get that binding

Status: RESOLVED WONTFIX

(Firefox :: Tabbed Browser, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

+++ This bug was initially created as a clone of Bug #1143038 +++

This is a follow-up for bug 1143038.

Comment 1

[Dão Gottwald [:dao]]

Could you please elaborate on what exactly needs to happen here?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think we would need to:

1. Remove this code:
http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/browser/base/content/tabbrowser.css#13-15

2. Always set clicktoscroll="true" to true on the arrowscrollbox element here:
http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/browser/base/content/tabbrowser.xml#5637

(So instead of doing it using CSS, we're doing it via an attribute, which is controlled here:
http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/toolkit/content/xul.css#1007
)

I'm not sure why I didn't make that change after the review. It seems simple enough now.

Comment 3

[Dão Gottwald [:dao]]

(In reply to Bill McCloskey (:billm) from comment #2)
> I think we would need to:
> 
> 1. Remove this code:
> http://searchfox.org/mozilla-central/rev/
> 9af9b1c7946ebef6056d2ee4c368d496395cf1c8/browser/base/content/tabbrowser.
> css#13-15

That's tabbrowser.xml#tabbrowser-arrowscrollbox.

> 2. Always set clicktoscroll="true" to true on the arrowscrollbox element
> here:
> http://searchfox.org/mozilla-central/rev/
> 9af9b1c7946ebef6056d2ee4c368d496395cf1c8/browser/base/content/tabbrowser.
> xml#5637
> 
> (So instead of doing it using CSS, we're doing it via an attribute, which is
> controlled here:
> http://searchfox.org/mozilla-central/rev/
> 9af9b1c7946ebef6056d2ee4c368d496395cf1c8/toolkit/content/xul.css#1007
> )

And this is scrollbox.xml#arrowscrollbox-clicktoscroll, so I don't really see how we could do that.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Oh right. tabbrowser.xml#tabbrowser-arrowscrollbox inherits from scrollbox.xml#arrowscrollbox-clicktoscroll:
http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/browser/base/content/tabbrowser.xml#5547

I'm not sure how to fix this then. Neil, I filed this based on https://bugzilla.mozilla.org/show_bug.cgi?id=1143038#c3. I'm not sure how to fix it though. Maybe we should just WONTFIX?

Comment 5

[Neil Deakin]

I've no idea what I was referring to there anymore, so I'm ok just closing this.