1145738 - JS Tree View/Flamegraph sometimes doesn't render any frames

Status: RESOLVED WORKSFORME

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Can't consistently recreate this, but once it fails, it seems to fail until restart. It's like no profiler data exists.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

What happens is the profiler start time is X, and when we receive the samples from the back end, all the samples have times < X, so no samples are rendered. this is very bad. Maybe this only happens when you have the profiler running for awhile. All my sample profiles are only about 2-3 seconds long.

earliest time, latest time, profiler start time
3244051 - 3270404 - 3390269

3440575.5 - 3466624 - 3552771

3924127.5 - 3950841.5 - 4048497

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

It seems as if some point, the profiler restarted, and gProfilerStartTime was not reset. Causing our profiler start time from startProfiler() (so Date.now() - gProfilerStartTime) to no longer match the internal timing used by profiler to match its samples.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

To clarify, with no toolboxes open or anything, and opening a new toolbox to start a new recording, the profiler is considered "active"

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

This is more than a papercut - this makes all of the profiler literally unusable

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Seeing this in old profiler in Fx38 as well. I think it mostly happens with long running instances.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Haven't seen this in awhile, but we need to keep an eye on this and ensure this doens't happenf or long running instances.

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Haven't seen this at all, luckily.. CLOSING