1145751 - [Settings][Call Forwarding] A grey box (square) flickers on the right side of the screen when changing Call Forwarding settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Martin Shuman [:Marty]]

Attachment: logcat-call-forward-flicker.txt

Description:
When the user changes a call forwarding setting, a confirmation screen will appear indicating the operation did or did not succeed. When this happens, a grey box will briefly flicker on the right side of the screen.


Repro Steps:
1) Update a Flame to 20150320010204
2) Open the Settings app and navigate to Call Settings > Call Forwarding
3) Select Always Forward, input a phone number and enable the feature.
4) Observe the confirmation screen that appears after the operation completes.

Actual:
A grey box will briefly flicker on the right side of the screen.

Expected:
The confirmation screen appears without graphical issues.

Environmental Variables:
Device: Flame 3.0 (319MB)(Full Flash)
Build ID: 20150320010204
Gaia: 8837f94418d69a0b06c1f4843b0779e2bb72165a
Gecko: 4d2d97b3ba34
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Repro frequency: 5/5
See attached: logcat, video (URL)

Comment 1

[Martin Shuman [:Marty]]

This issue DOES occur on Flame 2.2
A grey box will briefly flicker on the right side of the screen.

Environmental Variables:
Device: Flame 2.2 (319MB)(Full Flash)
Build ID: 20150320002502
Gaia: c8136ef4094fc5509551ab7b1d5f6141491f00ef
Gecko: 12139abae350
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.

-------------------

This issue does NOT occur on Flame 2.1
The confirmation screen appears without graphical issues.

Environmental Variables:
Device: Flame 2.1 (319MB)(Full Flash)
Build ID: 20150320001203
Gaia: 13c85d57f49b4bfd657ff674f2b530c141c94803
Gecko: 76bf2f0c7f07
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision, note is a regression.

Comment 3

[Hermes Cheng (inactive after July 27, 2015)]

Not sure what is the issue. Did you mean a sudden flash of the scroll bar at the right side?

Comment 4

[Martin Shuman [:Marty]]

Yes. The flashing grey box on the right side is the issue. I'm not entirely sure if it is the scrollbar or a different graphical issue, but it is in that area of the screen.

Comment 5

[Hermes Cheng (inactive after July 27, 2015)]

Hi Fred,
Could you take a look?

Comment 6

[[e-mail]]

Currently I'm occupied on other issue and I think EJ has more experience on call forwarding related issues, I'd refer him for help.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] EragonJ:bug-1145751 > mozilla-b2g:master

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After checking codebase for a while, this is a bug in gaia-components instead of Settings app. No matter how, I think this patch did fix the problem.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8592677 [details] [review]
[gaia] EragonJ:bug-1145751 > mozilla-b2g:master

Kevin, can you help me review this patch ?

Any idea / comment would be appreciated. thanks

Comment 10

[Kevin Grandon :kgrandon]

I am worried that this is going to cause some regressions if any confirm dialogs use a scrollable area, which some do I think. I would rather have some graphics guys investigate the root cause here, but I will look at this soon. Thanks.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Is there any other place using that for scrollable area ? I tried to find anyone before removing the CSS but with no luck.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

http://jsbin.com/qizamizedi/1/edit?output

@Kevin, if you check my experimental jsbin, you can notice that at first, the div is "overflow-y: hidden;", but later after 3 mins, I add one class on it to make it "overflow-y: scroll;", and you will see that all browsers (I tested on Safari, Nightly, Chrome on my Mac) would show the scrollbar for a moment and then hide it.

After thinking for a while, I realize that this native behavior is reasonable. If the browser don't show the scrollbar at first, how can users know that this field is scrollable ?

But for my case, there is no much strings that needs a scrollbar, so even if we add "overflow-y: scroll;" here should not show the scrollbar, so this is the place that you want graphics guys to investigate the root cause ?

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8592677 [details] [review]
[gaia] EragonJ:bug-1145751 > mozilla-b2g:master

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #12)
> http://jsbin.com/qizamizedi/1/edit?output
> 
> @Kevin, if you check my experimental jsbin, you can notice that at first,
> the div is "overflow-y: hidden;", but later after 3 mins, I add one class on
> it to make it "overflow-y: scroll;", and you will see that all browsers (I
> tested on Safari, Nightly, Chrome on my Mac) would show the scrollbar for a
> moment and then hide it.
> 
> After thinking for a while, I realize that this native behavior is
> reasonable. If the browser don't show the scrollbar at first, how can users
> know that this field is scrollable ?

I don't think it's necessary to show the scrollbar if you can't actually scroll the container.


> But for my case, there is no much strings that needs a scrollbar, so even if
> we add "overflow-y: scroll;" here should not show the scrollbar, so this is
> the place that you want graphics guys to investigate the root cause ?

I find it highly unlikely that we've tested all of the possible locales and checked various form factors to know this is true.

That said, I think it's probably ok to land this - hopefully we won't find any regressions.

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Okay, I think I can try to land this patch on master for a while and see whether this change would break any stuffs. If there is no regression bug coming up, I will ask 2.2 approval for this. Otherwise, we would backout this patch and ask some graphics guys' for help.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Put ni? on me to make sure I would remember to check 2.2 status for this bug.

Comment 16

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Landed at Gaia/master by myself : https://github.com/mozilla-b2g/gaia/commit/ea4cd61ac1a586961234764435cb0fe19f3a9286

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Things look nice for few days, feel free to tag me if there is any regression bug !

Comment 19

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: There is no any grey box (square) or scrollbar on the right side of the screen when user changes 'Call Forwarding' settings.
See attachment: verified_v3.0.3gp
Reproduce rate: 0/10


Device: Flame v3.0 build(Verified)
Build ID               20150628160206
Gaia Revision          8a1e4ae522c121c5cacd39b20a5386ec9055db82
Gaia Date              2015-06-25 21:58:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eaf4f9b45117
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150628.193057
Firmware Date          Sun Jun 28 19:31:08 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Verified)
Build ID               20150628160206
Gaia Revision          8a1e4ae522c121c5cacd39b20a5386ec9055db82
Gaia Date              2015-06-25 21:58:25
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/eaf4f9b45117
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150628.192615
Firmware Date          Sun Jun 28 19:26:32 EDT 2015
Bootloader             HHZ12f

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.3gp

Comment 21

[Shally Li（leave from Mozilla）]

Hi Josh,
     
    This is a regression bug, now v3.0 is verified.  Could you help to confirm whether it will uplift approval to v2.2?  Thanks.

Comment 22

[Josh Cheng [:josh]]

Hi Shally,
Although this is regression but it does not block function. I am marking this wontfix in 2.2.
Thanks!