Closed
Bug 1145775
Opened 9 years ago
Closed 9 years ago
Update pseudo l10n matching in gaia_grid
Categories
(Firefox OS Graveyard :: Gaia::Components, defect)
Tracking
(b2g-v2.2 unaffected, b2g-master fixed)
RESOLVED
FIXED
2.2 S9 (3apr)
| Tracking | Status | |
|---|---|---|
| b2g-v2.2 | --- | unaffected |
| b2g-master | --- | fixed |
People
(Reporter: zbraniecki, Assigned: zbraniecki)
Details
Attachments
(1 file)
Spin off from bug 1142758 - we need to update the buggy behavior of pseudolocales in gaia_grid/mozapps scenario
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8580885 -
Flags: review?(stas)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8580885 [details] [review] [gaia] zbraniecki:1145775-update-qps-behavior > mozilla-b2g:master Sweet. Thanks, Zibi!
Attachment #8580885 -
Flags: review?(stas) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Commit: https://github.com/mozilla-b2g/gaia/commit/27fceedca0cd0998246fbfb4cdc940d6dcc2dc8e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8580885 [details] [review] [gaia] zbraniecki:1145775-update-qps-behavior > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): never worked properly [User impact] if declined: double-translated appNames when using build-time pseudlocale [Testing completed]: master, device [Risk to taking this patch] (and alternatives if risky): none [String changes made]: none It's a minor patch, not necessary, but low risk and would be nice to have the right behavior while testing 2.2, so requesting approval.
Attachment #8580885 -
Flags: approval-gaia-v2.2?
|
||
Updated•9 years ago
|
Attachment #8580885 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
|
||
Comment 5•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/75d1a58f654f4feb0a775b65b3250a4215a28436
|
|
||
Comment 6•9 years ago
|
||
Reverted from v2.2 for making Gaia tests very unhappy. v2.2: https://github.com/mozilla-b2g/gaia/commit/f9f62d7b69c9d46a28b5ca4f18993c90b5a2b26a https://treeherder.mozilla.org/logviewer.html#?job_id=85185&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85178&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85173&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85187&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85186&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85172&repo=mozilla-b2g37_v2_2 https://treeherder.mozilla.org/logviewer.html#?job_id=85177&repo=mozilla-b2g37_v2_2
Flags: needinfo?(gandalf)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8580885 [details] [review] [gaia] zbraniecki:1145775-update-qps-behavior > mozilla-b2g:master I misunderstood the qps change patch. Stas decided not to land them for 2.2, so this patch is not needed there. Apologies Ryan and thanks for backing it out!
Flags: needinfo?(gandalf)
Attachment #8580885 -
Flags: approval-gaia-v2.2+
|
|
Assignee | |
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•