1145792 - Add a test for the Cache.keys method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Add a test for the Cache.keys method

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8580893 [details] [diff] [review]
Add a test for the Cache.keys method

Review of attachment 8580893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/cache/test/mochitest/test_cache_keys.js
@@ +19,5 @@
> +}).then(function(keys) {
> +  is(keys.length, tests.length, "Same number of elements");
> +  keys.forEach(function(r, i) {
> +    ok(r instanceof Request, "Valid request object");
> +    ok(r.url.indexOf(tests[i]) >= 0, "Valid URL");

Maybe indicate you are validating the order here as well.

Note, if a particular addAll() entry is very slow to load its body, then we probably mis-order the addAll() entries in sqlite.  This should be fixed when we implement bug 1110137.

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e30f28652715

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e30f28652715