Add a test for the Cache.keys method

RESOLVED FIXED in Firefox 39

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8580893 [details] [diff] [review]
Add a test for the Cache.keys method
Attachment #8580893 - Flags: review?(bkelly)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1110493

Comment 2

3 years ago
Comment on attachment 8580893 [details] [diff] [review]
Add a test for the Cache.keys method

Review of attachment 8580893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/cache/test/mochitest/test_cache_keys.js
@@ +19,5 @@
> +}).then(function(keys) {
> +  is(keys.length, tests.length, "Same number of elements");
> +  keys.forEach(function(r, i) {
> +    ok(r instanceof Request, "Valid request object");
> +    ok(r.url.indexOf(tests[i]) >= 0, "Valid URL");

Maybe indicate you are validating the order here as well.

Note, if a particular addAll() entry is very slow to load its body, then we probably mis-order the addAll() entries in sqlite.  This should be fixed when we implement bug 1110137.
Attachment #8580893 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/e30f28652715
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.