Remove LJSCallInstructionHelper::numStackArgs()

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: efaust, Assigned: efaust)

Tracking

unspecified
mozilla40
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This unfortunate function with the same name as MCall::numStackArgs(), subtracts 1 from the number. This makes unsupecting people not In The Know (like me, just now) throw a big animated exclamation point over their heads when reading code.

Let's remove it, as it obscures more meaning than it provides.
(Assignee)

Comment 1

4 years ago
Created attachment 8580924 [details] [diff] [review]
fix
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Attachment #8580924 - Flags: review?(jdemooij)
Comment on attachment 8580924 [details] [diff] [review]
fix

Review of attachment 8580924 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this footgun.
Attachment #8580924 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/9db244d84c0b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.