Closed Bug 1145795 Opened 10 years ago Closed 10 years ago

Remove LJSCallInstructionHelper::numStackArgs()

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: efaust, Assigned: efaust)

Details

Attachments

(1 file)

This unfortunate function with the same name as MCall::numStackArgs(), subtracts 1 from the number. This makes unsupecting people not In The Know (like me, just now) throw a big animated exclamation point over their heads when reading code. Let's remove it, as it obscures more meaning than it provides.
Attached patch fixSplinter Review
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
Attachment #8580924 - Flags: review?(jdemooij)
Comment on attachment 8580924 [details] [diff] [review] fix Review of attachment 8580924 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this footgun.
Attachment #8580924 - Flags: review?(jdemooij) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: