1145795 - Remove LJSCallInstructionHelper::numStackArgs()

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Eric Faust [:efaust]]

This unfortunate function with the same name as MCall::numStackArgs(), subtracts 1 from the number. This makes unsupecting people not In The Know (like me, just now) throw a big animated exclamation point over their heads when reading code.

Let's remove it, as it obscures more meaning than it provides.

Comment 1

[Eric Faust [:efaust]]

Attachment: fix

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8580924 [details] [diff] [review]
fix

Review of attachment 8580924 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this footgun.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9db244d84c0b