Closed Bug 11458 Opened 21 years ago Closed 21 years ago

compiler warning

Categories

(Core :: DOM: Core & HTML, defect, P3)

All
Mac System 8.5
defect

Tracking

()

CLOSED FIXED

People

(Reporter: Brade, Assigned: norrisboyd)

References

Details

In mozilla/dom/src/base/nsJSSecurityManager.cpp
in nsJSSecurityManager::SetContainerPrincipals()

a warning from the Macintosh compiler:
possible unintended semi-colon (line 829)

This can be fixed by moving the semicolon to a new line or enclosing it in {}.

The reason I recommend this particular warning be fixed is that someone might see
the warning and make the wrong assumption on how to fix the warning and we'd have
a hard time tracking down this kind of a bug if it were incorrectly fixed.
Summary: compiler warning on Macintosh → [PP]compiler warning on Macintosh
Setting on [pp] radar.
Hardware: Macintosh → All
Summary: [PP]compiler warning on Macintosh → compiler warning
removing [PP] designation as this code is cross-platform.  I'd guess that this
same warning appears on other platforms as well.
Status: NEW → ASSIGNED
I'm assuming this warning is for the line
  while (nsnull != (aContainer = JS_GetParent(aCx, aContainer)));
I think that this line is incorrect anyway: aContainer will always be null on
exit from the loop. I don't think joki had a chance to test this code.
yes, that is the line of code being flagged.
Target Milestone: M10
Blocks: 12633
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Function and file removed as part of general cleanup.
Status: RESOLVED → CLOSED
closing bug; file is no longer in the current tree
You need to log in before you can comment on or make changes to this bug.