11458 - compiler warning

Status: CLOSED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Kathleen :Brade]

In mozilla/dom/src/base/nsJSSecurityManager.cpp
in nsJSSecurityManager::SetContainerPrincipals()

a warning from the Macintosh compiler:
possible unintended semi-colon (line 829)

This can be fixed by moving the semicolon to a new line or enclosing it in {}.

The reason I recommend this particular warning be fixed is that someone might see
the warning and make the wrong assumption on how to fix the warning and we'd have
a hard time tracking down this kind of a bug if it were incorrectly fixed.

Comment 1

[leger]

Setting on [pp] radar.

Comment 2

[Kathleen :Brade]

removing [PP] designation as this code is cross-platform.  I'd guess that this
same warning appears on other platforms as well.

Comment 3

[Norris Boyd]

I'm assuming this warning is for the line
  while (nsnull != (aContainer = JS_GetParent(aCx, aContainer)));
I think that this line is incorrect anyway: aContainer will always be null on
exit from the loop. I don't think joki had a chance to test this code.

Comment 4

[Kathleen :Brade]

yes, that is the line of code being flagged.

Comment 5

[Norris Boyd]

Function and file removed as part of general cleanup.

Comment 6

[Kathleen :Brade]

closing bug; file is no longer in the current tree