114581 - table.deleteRow() exception not thrown

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bernd]

http://www.w3.org/TR/2001/WD-DOM-Level-2-HTML-20011210/html.html#ID-64060425

Indicates that deleteRow() should throw an exeption if the row index to large or
to small.

Comment 1

[Bernd]

Attachment: testcase

Comment 2

[Johnny Stenback (:jst)]

Attachment: Proposed fix.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 61232 [details] [diff] [review]
Proposed fix.

r=glazman

Comment 4

[jag (Peter Annema)]

Comment on attachment 61232 [details] [diff] [review]
Proposed fix.

>-  if (row) {
>-    nsCOMPtr<nsIDOMNode> parent=nsnull;
>+  if (!row) {
>+    return NS_ERROR_DOM_INDEX_SIZE_ERR;
>+  }
> 
>-    row->GetParentNode(getter_AddRefs(parent));
>+  nsCOMPtr<nsIDOMNode> parent=nsnull;

I know you're just reindenting this, but there's no need for the nsnull
assignment here.

sr=jag if you change that.

Comment 5

[Johnny Stenback (:jst)]

Good catch, no more null assignment.

FIXED.

Comment 6

[Sivakiran Tummala]

verified fixed. 2001-12-20-10.