table.deleteRow() exception not thrown

VERIFIED FIXED in mozilla0.9.7

Status

()

VERIFIED FIXED
17 years ago
11 years ago

People

(Reporter: bernd_mozilla, Assigned: jst)

Tracking

({testcase})

Trunk
mozilla0.9.7
x86
Windows 98
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [HAVE FIX])

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
http://www.w3.org/TR/2001/WD-DOM-Level-2-HTML-20011210/html.html#ID-64060425

Indicates that deleteRow() should throw an exeption if the row index to large or
to small.
(Reporter)

Comment 1

17 years ago
Created attachment 61230 [details]
testcase
(Reporter)

Updated

17 years ago
Keywords: testcase
(Assignee)

Comment 2

17 years ago
Created attachment 61232 [details] [diff] [review]
Proposed fix.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.7
Comment on attachment 61232 [details] [diff] [review]
Proposed fix.

r=glazman
Attachment #61232 - Flags: review+

Comment 4

17 years ago
Comment on attachment 61232 [details] [diff] [review]
Proposed fix.

>-  if (row) {
>-    nsCOMPtr<nsIDOMNode> parent=nsnull;
>+  if (!row) {
>+    return NS_ERROR_DOM_INDEX_SIZE_ERR;
>+  }
> 
>-    row->GetParentNode(getter_AddRefs(parent));
>+  nsCOMPtr<nsIDOMNode> parent=nsnull;

I know you're just reindenting this, but there's no need for the nsnull
assignment here.

sr=jag if you change that.
Attachment #61232 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
Good catch, no more null assignment.

FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
verified fixed. 2001-12-20-10.
Status: RESOLVED → VERIFIED

Updated

11 years ago
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.