1145811 - Clean-up: Remove simdSet argument of PushRegsInMask.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Remove simdSet argument of PushRegsInMask.

Noite: This patch is based on Bug 1143011 modififcations, which renames the
arguments to have a Live prefix to which indicate that the registers are
ideally the result of a register allocator.

Also, reduceSetForPush got also changed to effectively reduce the set of
register to only produce non-overlapping registers, as GetPushSizeInBytes
would return, at the same time where the iterator changed for non longer
iterating over Allocatable register, but over live registers.

The only major difference in terms of generated code when compared to the version
which was set before Bug 1143011 is that instead of doing a storeUnalignedInt32x4, we
are doing a storeUnalignedFloat32x4 for unknown SIMD registers.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8580914 [details] [diff] [review]
Remove simdSet argument of PushRegsInMask.

Review of attachment 8580914 [details] [diff] [review]:
-----------------------------------------------------------------

Alright.

::: js/src/jit/shared/MacroAssembler-x86-shared.cpp
@@ +17,2 @@
>  {
> +    FloatRegisterSet doubleSet(set.fpus().reduceSetForPush());

nit: doubleSet isn't an appropriate name anymore. How about floatingPointSet or fpSet or fpuSet?

@@ +57,2 @@
>  {
> +    FloatRegisterSet doubleSet(set.fpus().reduceSetForPush());

ditto

Comment 3

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8787eda5c93e

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8787eda5c93e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This was backed out from Aurora39 due to bug 1149377.
https://hg.mozilla.org/releases/mozilla-aurora/rev/759eb70deb31

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Re-landed on Aurora.