Clean-up: Remove simdSet argument of PushRegsInMask.

RESOLVED FIXED in Firefox 39

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nbp, Assigned: nbp)

Tracking

Trunk
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed, firefox40 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8580914 [details] [diff] [review]
Remove simdSet argument of PushRegsInMask.

Noite: This patch is based on Bug 1143011 modififcations, which renames the
arguments to have a Live prefix to which indicate that the registers are
ideally the result of a register allocator.

Also, reduceSetForPush got also changed to effectively reduce the set of
register to only produce non-overlapping registers, as GetPushSizeInBytes
would return, at the same time where the iterator changed for non longer
iterating over Allocatable register, but over live registers.

The only major difference in terms of generated code when compared to the version
which was set before Bug 1143011 is that instead of doing a storeUnalignedInt32x4, we
are doing a storeUnalignedFloat32x4 for unknown SIMD registers.
Attachment #8580914 - Flags: review?(benj)
Comment on attachment 8580914 [details] [diff] [review]
Remove simdSet argument of PushRegsInMask.

Review of attachment 8580914 [details] [diff] [review]:
-----------------------------------------------------------------

Alright.

::: js/src/jit/shared/MacroAssembler-x86-shared.cpp
@@ +17,2 @@
>  {
> +    FloatRegisterSet doubleSet(set.fpus().reduceSetForPush());

nit: doubleSet isn't an appropriate name anymore. How about floatingPointSet or fpSet or fpuSet?

@@ +57,2 @@
>  {
> +    FloatRegisterSet doubleSet(set.fpus().reduceSetForPush());

ditto
Attachment #8580914 - Flags: review?(benj) → review+
Depends on: 1143011
https://hg.mozilla.org/mozilla-central/rev/8787eda5c93e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Depends on: 1149377
This was backed out from Aurora39 due to bug 1149377.
https://hg.mozilla.org/releases/mozilla-aurora/rev/759eb70deb31
status-firefox39: fixed → affected
status-firefox40: --- → fixed
Re-landed on Aurora.
status-firefox39: affected → fixed
You need to log in before you can comment on or make changes to this bug.