1145812 - "ASSERTION: nsTDependentString must wrap only null-terminated strings" with dom.url.encode_decode_hash

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Set:
     user_pref("dom.url.encode_decode_hash", true);
   [This pref was added in bug 1093611, for restoring old behavior.]
2. Load the testcase in a debug build

###!!! ASSERTION: nsTDependentString must wrap only null-terminated strings. You are probably looking for nsTDependentSubstring.: 'mData[mLength] == 0', file nsTString.h, line 455

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Valentin Gosu [:valentin] (he/him) [vacation until Aug 1st]]

Attachment: Fix assertion with dom.url.encode_decode_hash pref set to true

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8581054 [details] [diff] [review]
Fix assertion with dom.url.encode_decode_hash pref set to true

Review of attachment 8581054 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsStandardURL.cpp
@@ +2513,5 @@
>          mRef.mPos = mSpec.Length();
>          mRef.mLen = 0;
>      }
>  
> +    nsAutoCString buf;

please comment how this memory ends up attached to another variable and how it is used below.. its obviously not intuitive :)

Comment 4

[Valentin Gosu [:valentin] (he/him) [vacation until Aug 1st]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21695668595d

Comment 5

[Ryan VanderMeulen [Away July 12-26]]

https://hg.mozilla.org/mozilla-central/rev/21695668595d

Comment 6

[Valentin Gosu [:valentin] (he/him) [vacation until Aug 1st]]

Comment on attachment 8581054 [details] [diff] [review]
Fix assertion with dom.url.encode_decode_hash pref set to true

Approval Request Comment
[Feature/regressing bug #]:
Bug 1093611

[User impact if declined]:
Blocks Bug 1149913 from being uplifted to beta.

[Describe test coverage new/current, TreeHerder]:
This code is currently on aurora. Manual testing.

[Risks and why]: 
Very low risk. This is a trivial bug, with an obvious fix.

[String/UUID change made/needed]:
None.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8581054 [details] [diff] [review]
Fix assertion with dom.url.encode_decode_hash pref set to true

Should be in 38 beta 7

Comment 8

[Ryan VanderMeulen [Away July 12-26]]

https://hg.mozilla.org/releases/mozilla-release/rev/5f0e381a7afd

Comment 9

[Ryan VanderMeulen [Away July 12-26]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f0e381a7afd