1145882 - Add --version to shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: Part 1: Only use $PYTHON after defined by MOZ_PYTHON

mkedlaya_ on IRC had an old JS shell around and wanted to know the build information. Adding --version would be standard and handy.

Part 1 fixes a bug where the version information would be omitted from the version string, because $PYTHON isn't yet defined at the point of invocation.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: Part 2: Add --version.

Adds -v and --version to the shell as an option with special handling.

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8580966 [details] [diff] [review]
Part 2: Add --version.

Review of attachment 8580966 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/jsoptparse.cpp
@@ +255,5 @@
>  
>  OptionParser::Result
> +OptionParser::printVersion(const char *progname)
> +{
> +    MOZ_ASSERT(ver);

Ugh, I guess `version` is really too long.

@@ +257,5 @@
> +OptionParser::printVersion(const char *progname)
> +{
> +    MOZ_ASSERT(ver);
> +    printf("%s\n", ver);
> +    return ParseHelp;

I would rename this to EarlyExit.

Comment 3

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f8bbef85715
https://hg.mozilla.org/integration/mozilla-inbound/rev/96aef1037d39

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f8bbef85715
https://hg.mozilla.org/mozilla-central/rev/96aef1037d39