1145936 - <foreignObject style="writing-mode: vertical-lr;" /> trips an assertion

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: reflow state made child wrong size: 'reflowState.ComputedWidth() == mRect.width', file layout/svg/nsSVGForeignObjectFrame.cpp, line 553

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Ruderman]

Testcase requires:
  user_pref("layout.css.vertical-text.enabled", true);

Comment 3

[Jonathan Kew [:jfkthame]]

It doesn't just trip an assertion, it also renders incorrectly (if there's any actual content to render).

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Fix sizing of foreignObject with vertical writing mode

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for sizing of foreignObject with vertical writing mode

Here's a simple reftest that renders incorrectly (when writing-mode is enabled) until the bug is fixed.

Comment 6

[Jesse Ruderman]

If the pref can be changed during a session, you can force it on for a specific reftest, like this:

> pref(layout.css.vertical-text.enabled,true)  == foreignObject-vertical-01.svg foreignObject-vertical-01-ref.svg

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 8582357 [details] [diff] [review]
Fix sizing of foreignObject with vertical writing mode

Review of attachment 8582357 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/nsSVGForeignObjectFrame.cpp
@@ +548,5 @@
>    NS_ASSERTION(reflowState.ComputedPhysicalBorderPadding() == nsMargin(0, 0, 0, 0) &&
>                 reflowState.ComputedPhysicalMargin() == nsMargin(0, 0, 0, 0),
>                 "style system should ensure that :-moz-svg-foreign-content "
>                 "does not get styled");
> +  NS_ASSERTION(reflowState.ComputedISize() == GetLogicalSize(wm).ISize(wm),

reflowState.ComputedISize() == ISize(wm)

@@ +553,2 @@
>                 "reflow state made child wrong size");
> +  reflowState.SetComputedBSize(GetLogicalSize(wm).BSize(wm));

reflowState.SetComputedBSize(BSize(wm));

Comment 8

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55df5a95d7df
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a966d61821b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55df5a95d7df
https://hg.mozilla.org/mozilla-central/rev/4a966d61821b