1145971 - URL bar long press context menu

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Corey Shields [:cshields]]

When a page is loaded and you click the url bar, the view of the tab goes away and is switched to the about:home view.

So, in the workflow of copying a URL out of the bar, one has to "cancel" out of this view to go back to the page they were on.  My expectation as a user would be that going to the url bar would not change the view of the page loaded.

Steps to reproduce:

1. go to some url (reddit.com)
2. tap the URL bar

results: the reddit view is replaced with the tiled about:home

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

This is the same Safari and Firefox on Android. If you want to copy the URL, we could make it easier. On Android we support a long-press on the URL toolbar, without going into edit mode.

Comment 2

[Corey Shields [:cshields]]

hah!!  Ok, you got me on this one - I never noticed that behavior in safari because I use chrome in iOS..  Just tried and sure enough the behavior does match that of safari's.   So, feel free to close this out - the long press copy would be a cool feature though.

Comment 3

[Matthew Purcell]

Attachment: Pull Request

Implemented the Copy Address, Paste & Go, and Paste behaviour as found in Firefox for Android.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Nominating this bug because it looks Matthew is very close to finishing this. But :darrin should probably have the final word on this UX-wise?

Comment 5

[Darrin Henein [:darrin]]

Just checked out this PR and it feels pretty good. Considering we have (most of) a patch I'm happy to include this in v1. We may want to finesse this interaction down the road, but I think its a nice feature to have included as is. ux+ from me ;)

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8588532 [details] [review]
Pull Request

Looks good, though the iPad crasher should be fixed before we can merge.

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 8588532 [details] [review]
Pull Request

Flagging for review since the PR was updated.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8588532 [details] [review]
Pull Request

Just noticed that Darrin/Stefan are marked as mentors here, and Stefan has given some feedback already in the PR, so flipping review to him.

Comment 9

[Matthew Purcell]

Comment on attachment 8588532 [details] [review]
Pull Request

PR has been squashed and rebased onto master, ready to be landed (hopefully...first time I have done this, so let me know if anything's wrong!).

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Merged.