1145974 - Move more styles to shared addressbook.css

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: sharedAB.patch

I've shared as much as I saw could be done.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: sharedAB.patch

Fixed the commit message.

Comment 3

[Josiah Bruner [:jsbruner]]

Comment on attachment 8581257 [details] [diff] [review]
sharedAB.patch

Review of attachment 8581257 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I just had a few comments/questions.

Comment 4

[Josiah Bruner [:jsbruner]]

Comment on attachment 8581257 [details] [diff] [review]
sharedAB.patch

Review of attachment 8581257 [details] [diff] [review]:
-----------------------------------------------------------------

... Which all disappeared ... *Sigh*

::: mail/themes/osx/mail/addrbook/addressbook.css
@@ -377,5 @@
>  
>  #abContent {
>    color: -moz-DialogText;
> -  text-shadow: none;
> -  background-color: -moz-Dialog;

Didn't we decide that we would only share if all selector rules matched?

@@ +554,1 @@
>    min-height: 19px; /* aqua size for small buttons */

Ditto.

::: mail/themes/windows/mail/addrbook/addressbook-aero.css
@@ -502,5 @@
> -  list-style-image: url("chrome://messenger/skin/addressbook/icons/ablist.png");
> -}
> -
> -treechildren::-moz-tree-cell-text(GeneratedName) {
> -  -moz-padding-start: 0 !important;

Ditto.

::: mail/themes/windows/mail/addrbook/addressbook.css
@@ +190,1 @@
>    border-top: 1px solid ThreeDShadow;

Ditto.

@@ -294,5 @@
> -  list-style-image: url("chrome://messenger/skin/addressbook/icons/ablist.png");
> -}
> -
> -treechildren::-moz-tree-cell-text(GeneratedName) {
> -  -moz-padding-start: 0 !important;

I assume you made sure this works now that the !important is gone?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: sharedAB.patch

Yes, you're right. This patch shares now only full matches.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Josiah Bruner [:JosiahOne] (needinfo! - Won't respond to CC)) from comment #4)
> Comment on attachment 8581257 [details] [diff] [review]
> sharedAB.patch
> 
> Review of attachment 8581257 [details] [diff] [review]:
> -----------------------------------------------------------------
> @@ -294,5 @@
> > -  list-style-image: url("chrome://messenger/skin/addressbook/icons/ablist.png");
> > -}
> > -
> > -treechildren::-moz-tree-cell-text(GeneratedName) {
> > -  -moz-padding-start: 0 !important;
> 
> I assume you made sure this works now that the !important is gone?

Yes, I haven't seen why this !important was set or is needed.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/423864cb6cba