Closed
Bug 1146068
Opened 9 years ago
Closed 9 years ago
Update reading list scheduler to match requirements of the sync engine
Categories
(Firefox Graveyard :: Reading List, defect)
Firefox Graveyard
Reading List
Tracking
(firefox38 fixed, firefox39 fixed)
RESOLVED
FIXED
Firefox 39
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(2 files)
11.08 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
2.83 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
Now we have a real RL sync engine, the scheduler needs some tweaks. Drew, you gave r+-over-the-shoulder of part of this, but I added some other things, in particular, that if an item is added/changed/etc while a sync is in progress we start a new sync immediately after the existing one completes - it may have missed that change and thus may be a long time before it is actually synced. This includes a test. We also had a preference for "how long after the RL is dirty until we sync" with a default of 2 mins, but talking with rnewman we decided this should be immediate - there's a good chance the user might add an item then shut their laptop - so that's been removed too.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Here are the log manager fixes we discussed - these are almost identical to what you have in the sync patch, but I also clarified an unrelated comment as I found it difficult to read. I figure we may as well keep it in this bug as it is part of the scheduler if you squint enough (ie, we rely on the scheduler to take care of RL logs)
Attachment #8581218 -
Flags: review?(adw)
Comment 2•9 years ago
|
||
Hi Mark, can you provide a point value.
Iteration: --- → 39.2 - 23 Mar
Flags: needinfo?(mhammond)
Assignee | ||
Updated•9 years ago
|
Points: --- → 2
Flags: needinfo?(mhammond)
Comment 3•9 years ago
|
||
Comment on attachment 8581217 [details] [diff] [review] 0005-fix-scheduler-to-match-readinglist-sync-engine-imple.patch Review of attachment 8581217 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/readinglist/Scheduler.jsm @@ +122,5 @@ > this._setupTimer(); > }, > > + _setupRLListener() { > + let maybeSync = () => { Just a nit, but this doesn't have to be inside _setupRLListener. IMO it should be a method on the scheduler. Just a suggestion, feel free to leave it as is.
Attachment #8581217 -
Flags: review?(adw) → review+
Updated•9 years ago
|
Attachment #8581218 -
Flags: review?(adw) → review+
Updated•9 years ago
|
Iteration: 39.2 - 23 Mar → 39.3 - 30 Mar
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c12a9bd2cc2b https://hg.mozilla.org/integration/fx-team/rev/497bcc0a0143
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c12a9bd2cc2b https://hg.mozilla.org/mozilla-central/rev/497bcc0a0143
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d93c3c3ac322 https://hg.mozilla.org/releases/mozilla-aurora/rev/20d4b2b21a8f
status-firefox38:
--- → fixed
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•