Stop using MOZ_OVERRIDE and MOZ_FINAL in comm-central. Instead use the override and final keywords.

RESOLVED FIXED in Thunderbird 39.0

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: philip.chee, Assigned: Ehsan)

Tracking

Trunk
Thunderbird 39.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird38 fixed)

Details

Attachments

(1 obsolete attachment)

Reporter

Description

4 years ago
(In Bug #1145631 comment #0)
> We can now use the override and final keywords.

(In Bug #1145631 comment #2)

> This patch was automatically generated using the following script:
> 
> 
> function convert() {
> echo "Converting $1 to $2..."
> find . \
>        ! -wholename "*/.git*" \
>        ! -wholename "obj-ff-dbg*" \
>          -type f \
>       \( -iname "*.cpp" \
>          -o -iname "*.h" \
>          -o -iname "*.c" \
>          -o -iname "*.cc" \
>          -o -iname "*.idl" \
>          -o -iname "*.ipdl" \
>          -o -iname "*.ipdlh" \
>          -o -iname "*.mm" \) | \
>     xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
> }
> 
> convert MOZ_OVERRIDE override
> convert MOZ_FINAL final
Reporter

Updated

4 years ago
Summary: Stop using MOZ_OVERRIDE and MOZ_FINAL instead use the override and final keywords. → Stop using MOZ_OVERRIDE and MOZ_FINAL in comm-central. Instead use the override and final keywords.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Posted patch patch, v3 (obsolete) — Splinter Review
Attachment #8581263 - Flags: review?(rkent)
Attachment #8581263 - Flags: review?(neil)

Comment 2

4 years ago
Is bug 810495 still needed or are all "final" keywords already placed where needed? I think I haven't seen those compiler warnings in a while.
I'm not sure, but that should probably be discussed on bug 810495. This bug is orthogonal to bug 810495.
Assignee

Comment 4

4 years ago
Comment on attachment 8581263 [details] [diff] [review]
patch, v3

There is no point in waiting for reviews here.  I'll fix this.
Attachment #8581263 - Attachment is obsolete: true
Attachment #8581263 - Flags: review?(rkent)
Attachment #8581263 - Flags: review?(neil)
Assignee

Comment 5

4 years ago
https://hg.mozilla.org/comm-central/rev/94adb5945ec3
Assignee: archaeopteryx → ehsan
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Since bug 1145631 was uplifted to aurora, I assume we need to do the same thing here (or at least my local builds are now breaking)
Pushed to comm-aurora https://hg.mozilla.org/releases/comm-aurora/rev/8e04fe92bd1f a=rkent
Target Milestone: --- → Thunderbird 39.0
Assignee

Comment 8

4 years ago
(In reply to Kent James (:rkent) from comment #7)
> Pushed to comm-aurora
> https://hg.mozilla.org/releases/comm-aurora/rev/8e04fe92bd1f a=rkent

Oh, thanks Kent for doing this, and sorry that I forgot to do this (twice)!
You need to log in before you can comment on or make changes to this bug.