1146094 - Stop using MOZ_OVERRIDE and MOZ_FINAL in comm-central. Instead use the override and final keywords.

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Philip Chee]

(In Bug #1145631 comment #0)
> We can now use the override and final keywords.

(In Bug #1145631 comment #2)

> This patch was automatically generated using the following script:
> 
> 
> function convert() {
> echo "Converting $1 to $2..."
> find . \
>        ! -wholename "*/.git*" \
>        ! -wholename "obj-ff-dbg*" \
>          -type f \
>       \( -iname "*.cpp" \
>          -o -iname "*.h" \
>          -o -iname "*.c" \
>          -o -iname "*.cc" \
>          -o -iname "*.idl" \
>          -o -iname "*.ipdl" \
>          -o -iname "*.ipdlh" \
>          -o -iname "*.mm" \) | \
>     xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
> }
> 
> convert MOZ_OVERRIDE override
> convert MOZ_FINAL final

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v3

Comment 2

[:aceman]

Is bug 810495 still needed or are all "final" keywords already placed where needed? I think I haven't seen those compiler warnings in a while.

Comment 3

[Daniel Holbert [:dholbert]]

I'm not sure, but that should probably be discussed on bug 810495. This bug is orthogonal to bug 810495.

Comment 4

[(no longer active)]

Comment on attachment 8581263 [details] [diff] [review]
patch, v3

There is no point in waiting for reviews here.  I'll fix this.

Comment 5

[(no longer active)]

https://hg.mozilla.org/comm-central/rev/94adb5945ec3

Comment 6

[Kent James (:rkent)]

Since bug 1145631 was uplifted to aurora, I assume we need to do the same thing here (or at least my local builds are now breaking)

Comment 7

[Kent James (:rkent)]

Pushed to comm-aurora https://hg.mozilla.org/releases/comm-aurora/rev/8e04fe92bd1f a=rkent

Comment 8

[(no longer active)]

(In reply to Kent James (:rkent) from comment #7)
> Pushed to comm-aurora
> https://hg.mozilla.org/releases/comm-aurora/rev/8e04fe92bd1f a=rkent

Oh, thanks Kent for doing this, and sorry that I forgot to do this (twice)!