1146097 - Incorrectly escaped regexp in webide-prefs.js

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Jesse Ruderman]

In browser/devtools/webide/webide-prefs.js:

> pref("devtools.webide.simulatorAddonRegExp", "fxos_(.*)_simulator@mozilla\.org$");

Trips a warning on a startup:

WARNING: preserving unexpected JS escape sequence: file modules/libpref/prefread.cpp, line 393

Assuming you want the parsed pref (and thus input to the regexp engine) to contain "\.", I think the prefs file should contain "\\."

Comment 1

[Jan Keromnes [:janx]]

Attachment: Incorrectly escaped regexp in webide-prefs.js.

Thanks for reporting this, Jesse!

> Assuming you want the parsed pref (and thus input to the regexp engine) to
> contain "\.", I think the prefs file should contain "\\."

That's indeed what was intended, fixed using your suggestion.

Comment 2

[Jan Keromnes [:janx]]

Attachment: Incorrectly escaped regexp in webide-prefs.js.

Comment 3

[Jan Keromnes [:janx]]

Thanks! We are ready for launch.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/db88094d97b2

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db88094d97b2