1146107 - Assertion failure in nsRubyBaseContainerFrame::Reflow with huge margin

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Assertion failure: (0 != ((aStatus) & 0x0100)) || isize == lineSpanSize || mFrames.IsEmpty(), at layout/generic/nsRubyBaseContainerFrame.cpp:520

>  MOZ_ASSERT(NS_INLINE_IS_BREAK(aStatus) ||
>             isize == lineSpanSize || mFrames.IsEmpty());

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

Attachment: stack

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

I don't see any serious problem could happen when this assertion is broken, hence just replace the assertion with a non-crash one.

Comment 4

[Daniel Holbert [:dholbert]]

As in bug 1146114, we may really want to relax this to NS_WARN_IF_FALSE(), and add a code-comment mentioning the bug number on adding a flag to documents with huge CSS sizes. (so we can make this assertion contingent on a document having reasonable sizes.)

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8585281 [details] [diff] [review]
patch

>-  MOZ_ASSERT(NS_INLINE_IS_BREAK(aStatus) ||
>-             isize == lineSpanSize || mFrames.IsEmpty());
>+  NS_ASSERTION(NS_INLINE_IS_BREAK(aStatus) ||
>+               isize == lineSpanSize || mFrames.IsEmpty(), "bad isize");

Similar to bug 1146114 comment 7: let's change this to NS_WARN_IF_FALSE instead, and add an XXX comment mentioning bug 765861, so that we remember to increase the severity once that bug's been addressed.

(And update the commit message mere accordingly.)

r=me with that

Comment 6

[Daniel Holbert [:dholbert]]

Also, we should take the testcase (or something that trips this assertion) as a crashtest.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d16094bbcf97

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d16094bbcf97