1146112 - Several assertions with ruby in grid

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Something went awry in our block parent calculations: '!aFrame->IsBoxFrame() || itemsToConstruct.AnyItemsNeedBlockParent() == (AnyKidsNeedBlockParent(aFrameItems.FirstChild()) != nullptr)', file src/layout/base/nsCSSFrameConstructor.cpp, line 10457

###!!! ASSERTION: No line layout provided to RubyFrame reflow method.: 'aReflowState.mLineLayout', file src/layout/generic/nsRubyFrame.cpp, line 140

###!!! ASSERTION: huh?: 'pfd->mFrame == aFrame', file src/layout/generic/nsLineLayout.cpp, line 445

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

I guess this probably could also happen with flexbox...

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8585285 [details] [diff] [review]
patch

Review of attachment 8585285 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsCSSFrameConstructor.cpp
@@ +10166,5 @@
> +  // All types of ruby frames need a block frame to provide line layout,
> +  // hence they are always line participant.
> +  newItem->mIsLineParticipant = disp->IsRubyDisplayType();
> +
> +  if (!disp->IsRubyDisplayType()) {

bool isRuby = disp->IsRubyDisplayType();
newItem->mIsLineParticipant = isRuby;
if (!isRuby) {

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

https://hg.mozilla.org/integration/mozilla-inbound/rev/969baf537e95

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/969baf537e95