114615 - "Search for" in selection context menu sure includes a lot

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P3)

Description

[Rune Skaug]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011210
BuildID:    2001121003

When selecting text that contains images, <br>/<p> tags etc. the "Search for"
menu item includes #10#13 and image location/alt text. See URL for demonstration.

Reproducible: Always
Steps to Reproduce:
1. Go to URL
2. Follow descriptions, select tree numbers, right click.
3. Look at the "Search for" menu item

Expected Results:  Stripped of the codes, only including visible text.

Comment 1

[Lasse Marøen]

Confirmed, winXP, 2001121003.

Comment 2

[Christopher Archer]

Confirmed, build 2001121003, WinNT SP6a

Comment 3

[sairuh (rarely reading bugmail)]

->search

Comment 4

[Samir Gehani]

We need to strip:
(*) whitespace of the form tabs, linefeeds, and carriage returns
(*) tags in the selection

Comment 5

[Dean Tessman]

wfm 2001121103 on win2k.

It never reads more than "Search for 'Test 1; select ...'"

Comment 6

[Samir Gehani]

Dean, 
Select only the digits 1, 2, the image, and then digit 3.  Don't select the
instructions.  This will display the problem.

Comment 7

[Samir Gehani]

Attachment: Strip cr, lf, tabs.

Comment 8

[Samir Gehani]

morse, please r.
alecf, please sr.

Will land this when landing the patch for bug 15176.

(Not stripping tags because the DOM's getSelection API munges the tags and
supplies strings that makes sense.)

Comment 9

[Dean Tessman]

well, isn't that pretty!  ok, forget that wfm comment.

Comment 10

[Stephen P. Morse]

Comment on attachment 61354 [details] [diff] [review]
Strip cr, lf, tabs.

r=morse

Comment 11

[Alec Flett]

Comment on attachment 61354 [details] [diff] [review]
Strip cr, lf, tabs.

sr=alecf

Comment 12

[Jerome Lacoste]

This patch is r, sr and risk is really minimal. Should perhaps be fixed. One
less in the the 0.9.7 long list :)

Comment 13

[Samir Gehani]

Checked in.

Comment 14

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]