Closed Bug 1146151 Opened 5 years ago Closed 4 years ago

update harfbuzz to upstream release 1.0.1

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: ionnv, Assigned: jfkthame)

References

()

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

http://cgit.freedesktop.org/harfbuzz/commit/?id=e3671b8f8bb339e8a563a9da9cd5069073200fec

Overview of changes leading to 0.9.40
Friday, March 20, 2015
=====================================

- Another hb-coretext crasher fix.  Ouch!
- Happy Norouz!

Overview of changes leading to 0.9.39
Wednesday, March 4, 2015
=====================================

- Critical hb-coretext fixes.
- Optimizations and refactoring; no functional change
  expected.
- Misc build fixes.
Depends on: 1113070
Whiteboard: [gfx-noted]
Summary: update harfbuzz to upstream release 0.9.40 → update harfbuzz to upstream release 0.9.41
FWIW, .42 will be coming later today.
Summary: update harfbuzz to upstream release 0.9.41 → update harfbuzz to upstream release 1.0.1
Now that HB 1.0.1 is out, with the Win10-style "universal" shaper included, we should go ahead and take an update. This will give us compatibility with a bunch of new scripts that are included in Win10 fonts such as Segoe UI Historic.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Minor update: removed the Android failure annotation from reftests/indic-shaping/balinese-1.html, as it now passes on all platforms with the new shaper.
Attachment #8640606 - Flags: review?(jdaggett)
Attachment #8640519 - Attachment is obsolete: true
Attachment #8640519 - Flags: review?(jdaggett)
Blocks: 729993
Comment on attachment 8640606 [details] [diff] [review]
Update harfbuzz to release 1.0.1, to pick up recent fixes and the new Universal Shaping Engine for Win10 parity

Review of attachment 8640606 [details] [diff] [review]:
-----------------------------------------------------------------

>     /* We really want to find a 'vert' feature if there's any in the font, no
>      * matter which script/langsys it is listed (or not) under.
>      * See various bugs referenced from:
>      * https://github.com/behdad/harfbuzz/issues/63 */
> 	
>     map->add_feature (HB_TAG ('v','e','r','t'), 1, F_GLOBAL | F_GLOBAL_SEARCH);

I suspect we need better standardization within OpenType here. I think Adobe's layout engines use a union of scripts when shaping CJK which is different from the harfbuzz model.
Attachment #8640606 - Flags: review?(jdaggett) → review+
(In reply to John Daggett (:jtd) from comment #6)

> >     /* We really want to find a 'vert' feature if there's any in the font, no
> >      * matter which script/langsys it is listed (or not) under.
> >      * See various bugs referenced from:
> >      * https://github.com/behdad/harfbuzz/issues/63 */
> > 	
> >     map->add_feature (HB_TAG ('v','e','r','t'), 1, F_GLOBAL | F_GLOBAL_SEARCH);
> 
> I suspect we need better standardization within OpenType here. I think
> Adobe's layout engines use a union of scripts when shaping CJK which is
> different from the harfbuzz model.

Possibly, though Behdad & I discussed this a bit, and at this point weren't convinced of a need for anything more complex. But this can certainly be reconsidered if experience suggests it's necessary.
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a1e0d8d8b26d979cde5f3fc6692677b2be212276
changeset:  a1e0d8d8b26d979cde5f3fc6692677b2be212276
user:       Jonathan Kew <jkew@mozilla.com>
date:       Mon Aug 03 10:15:45 2015 +0100
description:
Bug 1146151 - Update harfbuzz to release 1.0.1, to pick up recent fixes and the new Universal Shaping Engine for Win10 parity. r=jdaggett
https://hg.mozilla.org/mozilla-central/rev/a1e0d8d8b26d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Blocks: 1196463
You need to log in before you can comment on or make changes to this bug.