1146162 - Mozreview should have a way to file a new bug when pushing a review

Status: RESOLVED DUPLICATE of bug 1199485

(MozReview Graveyard :: Review Board: Extension, defect, P2)

Description

[(not currently active) Ted Mielczarek]

One thing we nailed down nicely in bzexport was adding a "--new" argument to file a new bug and then attach the patch to it. It's nice to not have to switch up your workflow and go to bugzilla just because you don't already have a bug on file.

mozreview should let us do this, probably just client-side in the extension would be fine.

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: allow clients to file bugs on the command line (bug 1146162) r?gps

mozreview: allow clients to file bugs on the command line (bug 1146162) r?gps

This puts the basic machinery in place to be able to file bugs on the command
line by adding more options to `hg push` modelled on what is done in bzexport.
A follow on bug will address dealing nicely with missing or incomplete options
like bzexport does.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8612907 [details]
MozReview Request: mozreview: allow clients to file bugs on the command line (bug 1146162) r?gps

https://reviewboard.mozilla.org/r/9665/#review8481

::: hgext/reviewboard/client.py:61
(Diff revision 1)
> +from bugsy import Bug, Bugsy, BugsyException

Unfortunately it's not that simple.

requests imports Python modules that aren't in the py2exe distribution that's currently part of MozillaBuild. (Fortunately this is changing in the upcoming MozillaBuild release.).

Until then, there are a number of Python standard library modules that we can't import on the client. This is the primary reason why the client extension is submitting review requests to the server via a custom protocol instead of e.g. making a call to a JSON web service. It is very sad.

::: hgext/reviewboard/client.py:837
(Diff revision 1)
> +    entry[1].append(('', 'new', False, _('File a new bug')))
> +    entry[1].append(('', 'title', '', _('Summary for the new bug')))
> +    entry[1].append(('', 'summary', '', _('Summary for the new bug')))
> +    entry[1].append(('', 'product', '', _('Product for the new bug')))
> +    entry[1].append(('', 'component', '', _('Component for the new bug')))
> +    entry[1].append(('', 'prodversion', '', _('Version for the new bug')))
> +    entry[1].append(('', 'comment', '', _('Comment for the new bug')))

I'm not crazy about adding global arguments to push. With the addition of `-c` to push, we're already at the point where I feel uncomfortable changing the behavior of a core Mercurial command. I think the next option will have us inventing a new Mercurial command to initiate code review :/

Comment 3

[Dan Minor [:dminor]]

Sigh :/ I thought I was safe since we're using Bugsy in another extension, but since I'm interested in doing this to support importing Github pull requests I'm going to migrate the work here into the Mozreview UI for pullrequests (Bug 1148297) where I can do crazy things like make calls to web services.

Comment 4

[Dan Minor [:dminor]]

We discussed this a bit in #ateam this morning and it sounds like an interactive prompt that shows up if you attempt to push to mozreview without having a bug id in one of your commit messages would be the way to go.

Comment 5

[Mark Côté [:mcote]]

As useful as this is, we're going to concentrate on UI confusion for now.

Comment 6

[Mark Côté [:mcote]]

Bug 1199485 has (slightly) more recent work on this; duping.