1146198 - incorrect compile warnings about errorStringNameForErrorCode() being unused

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #952493 comment 34 +++

There are several compile warnings like this one:
mailnews/compose/src/nsComposeStrings.h: At global scope:
mailnews/compose/src/nsComposeStrings.h:73:24: warning: 'const char16_t* nameForID(nsresult)' defined but not used [-Wunused-function]
 static const char16_t* errorStringNameForErrorCode(nsresult aCode)
                        ^
Also the function is compiled multiple times (in whole TB build) causing a row of warnings like these:
mailnews/compose/src/nsComposeStrings.h:123:5: warning: case value '5583115' not in enumerated type 'nsresult' [-Wswitch]
     case NS_MSG_CANCELLING:

May it be something with the function being static and in a .h file?

Comment 1

[:aceman]

Attachment: patch

This seems to work for me. However the final link is broken for me today, I'd like a try run of this to check if the function is found at final link of TB. Suyash, can you push it to try server?

Comment 2

[Suyash Agarwal (:sshagarwal)]

(In reply to :aceman from comment #1)
> Created attachment 8581357 [details] [diff] [review]
> patch
> 
> This seems to work for me. However the final link is broken for me today,
> I'd like a try run of this to check if the function is found at final link
> of TB. Suyash, can you push it to try server?

Sure
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=052a6d9c8bee

Comment 3

[:aceman]

Comment on attachment 8581357 [details] [diff] [review]
patch

Thanks, looks good on try.

Comment 4

[[e-mail]]

Comment on attachment 8581357 [details] [diff] [review]
patch

Fair enough, I guess.

Comment 5

[:aceman]

Thanks.

Comment 6

[Kent James (:rkent)]

Comment on attachment 8581357 [details] [diff] [review]
patch

http://hg.mozilla.org/comm-central/rev/4707841d802e

Comment 7

[Kent James (:rkent)]

Is there any reason this should go into TB 38?

Comment 8

[:aceman]

I do not see any reason. It is just code polish, no user visible change.

Comment 9

[Suyash Agarwal (:sshagarwal)]

Comment on attachment 8581357 [details] [diff] [review]
patch

Removing the feedback request as the patch is checked in :P