1146265 - [Aries][Nexus 5][Contacts] Creating new contact page does not fit the screen width.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Lance（leave from Mozilla）]

Attachment: 2015-03-23-16-53-08.png

[1.Description]:
According to comment 3 in Bug 1139312, this bug has been filed.
[Nexus 5 v2.2 & v3.0][Contacts] After you enter the creating new contact page, you can find that page does not display in full width of the screen.
Found time: 16:53
See attachment:2015-03-23-16-53-08.png and logcat_1653.txt

[2.Testing Steps]: 
1.Launch Contacts.
2.Tap "+" to enter creating new contact page.

[3.Expected Result]: 
2. The page should display in full width of the screen.

[4.Actual Result]: 
2.The page is displayed with space on the right.

[5.Reproduction build]: 
Nexus 5_2.2 version(Affected):
Build ID               20150322002503
Gaia Revision          44c62060581fde8de1e12e94cf55e9673b401a47
Gaia Date              2015-03-20 19:05:17
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/e6140a32902a
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150322.042453
Firmware Date          Sun Mar 22 04:25:09 EDT 2015
Bootloader             HHZ12d

Nexus 5_3.0 version(Affected):

Build ID               20150322160204
Gaia Revision          9b6f3024e4d0e62dd057231f4b14abe1782932ab
Gaia Date              2015-03-22 10:09:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e730012260a4
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150322.191717
Firmware Date          Sun Mar 22 19:17:33 EDT 2015
Bootloader             HHZ12d

Flame 2.2 version(Unaffected):
Build ID               20150322002503
Gaia Revision          44c62060581fde8de1e12e94cf55e9673b401a47
Gaia Date              2015-03-20 19:05:17
Gecko Revision         https://hg.mozilla.org/releases/mozilla-

b2g37_v2_2/rev/e6140a32902a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150322.043216
Firmware Date          Sun Mar 22 04:32:27 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]
The bug does not exist in Flame 2.2.

Comment 1

[Lance（leave from Mozilla）]

Attachment: logcat_1653.txt

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

It is about css layout, and I think it would impact some devices with different screen size.
Johan, do you know can take a look?

Comment 3

[Johan Lorenzo [:jlorenzo]]

This looks like a simple CSS change. However, the reference device is still the Flame for 2.2, so I don't see any reason to make this bug a blocker.

Either Fernando or Francisco can help here with this nice to have.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

CSS + Fernando != simple :|

Maybe Sergi :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Cleaning the ni, I'm sure Sergi can handle this.

Comment 6

[Lela(Leave from Mozilla)]

This bug can be repro on latest build of Aries KK v2.6 and Aries KK v2.5 by the STR in comment 0.

Actual results: The page is displayed with space on the right.
See attachment: Aries_v2.5.png&logcat_1644.txt
Reproduce rate: 10/10

Device:Aries KK v2.5 (Affected) 
Build ID               20151123164502
Gaia Revision          5839f17dedc757947c9531dc0d66c3c49119f5ea
Gaia Date              2015-11-20 22:47:58
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3a45ca93dd447e046baa2c7590f60ae008e438f8
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151123.155500
Firmware Date          Mon Nov 23 15:55:07 UTC 2015
Bootloader             s1

Device:Aries KK master (Affected) :
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1

Comment 7

[Lela(Leave from Mozilla)]

Attachment: Repro picture: Aries_v2.5.png

Comment 8

[Lela(Leave from Mozilla)]

Attachment: Repro log: logcat_1644.txt

Comment 9

[Isabel Rios[:isabel_rios]]

[Blocking Requested - why for this release]:The UX is broken for aries

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

Adding aries to title

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1146265 > mozilla-b2g:master

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8695259 [details] [review]
[gaia] arcturus:bug-1146265 > mozilla-b2g:master

Updating the css to make it responsive to different screens. ferjm r?

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/7b72e4e4bf1de20522119e73820856b19cf3581c

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Landed in nga:

71d71b0

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8695259 [details] [review]
[gaia] arcturus:bug-1146265 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bad design
[User impact] if declined:
Really bad user experience
[Testing completed]:
Tested on phone, aries, nexus5 and flame
[Risk to taking this patch] (and alternatives if risky):
Pretty low, is just CSS
[String changes made]:

Comment 17

[Lance（leave from Mozilla）]

Attachment: Verified picture: Aries master picture.PNG

This bug has been verified as "pass" on the latest build of Aries KK master and Nexus 5 L master by the STR in comment 0.
Actual result: The page displays in full width of the screen.
See attachmet: Aries KK master.png
Occurrence rate: 0/10.

Device: Aries KK master (pass)
Build ID               20151206002630
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151205.234548
Firmware Date          Sat Dec  5 23:45:56 UTC 2015
Bootloader             s1

Device: Nexus 5 L master (pass)
Build ID               20151206150208
Gaia Revision          b930e25e9f2e5ec2106dd31005468575cdf87d50
Gaia Date              2015-12-05 03:41:55
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc9c6cd756cb744596ba039dcc5ad3065a7cc3ea
Gecko Version          45.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20151206.183631
Firmware Date          Sun Dec  6 18:36:49 EST 2015
Bootloader             HHZ12k

Comment 18

[Mahendra Potharaju [:mahe]]

Comment on attachment 8695259 [details] [review]
[gaia] arcturus:bug-1146265 > mozilla-b2g:master

Limiting 2.5 only to TV patches. Foxfooders getting updates from master/b2g-ota branch. Removing the uplift nomination.

Thank you