114627 - Patch to allow closing Default Plugin dialog with ESC key

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[André Dahlqvist]

I think a lot of people want a quick way to close the Default Plugin dialog that
pops up way too often. I realize there is a bug already filed to make it
possible to not show it at all, but I would also like a quick way to close it
without having to dig for my mouse. Below I will attach a patch that makes the
ESC key close this dialog on UNIX.

Comment 1

[André Dahlqvist]

Attachment: Patch that adds the ability to close Default Plugin with ESC.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The default is being moved out of C++ and into xbl....

Comment 3

[André Dahlqvist]

I realized that later. Feel free to close this one.

Comment 4

[av (gone)]

--- Mass reassigning Unix bugs to serge ---

Comment 5

[serge (gone)]

André, thank you for patch,
I'm sorry, but I would like to mark this as WONTFIX,
because of default plugin will be replace with XBL one soon, see bug 83754.
Are you agree?

Comment 6

[André Dahlqvist]

Absolutely serge, I already agreed with that in comment 3. I'll close it myself now.

Comment 7

[shrirang khanzode]

v

Comment 8

[Boris Zbarsky [:bzbarsky]]

*** Bug 130538 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

Sorry, reopening.  Bug 83754 just got bumped yet again, and I doubt it's going
to land any time soon (like any time before the next netscape release).  It
would be good to at least have this annoyance somewhat controllable.

Comment 10

[serge (gone)]

actually default plugin's dialog is not a modal.
one simple click in browser window will bring all those dialogs underneath of 
browser window, and all of them are getting destroyed automatically on leaving 
the page with the plugins.

Comment 11

[Boris Zbarsky [:bzbarsky]]

> one simple click in browser window will bring all those dialogs underneath

No it won't because windows don't raise on click under a lot of windowmanager
setups...  Plus, why force me to go over to mouse to dismiss this dialog?  What
about keyboard-only users?

Comment 12

[Boris Zbarsky [:bzbarsky]]

And most importantly, this has a patch, so it's not a big time investment to fix
this.

Comment 13

[serge (gone)]

Comment on attachment 61258 [details] [diff] [review]
Patch that adds the ability to close Default Plugin with ESC.

sure the patch looks good to me, r=serge

Comment 14

[serge (gone)]

Attachment: disable popup default plugin dialog unix/gtk only

moreover I think it's not a good idea to bring up the dialog by default,
there is always way to click on puzzle icon to popup the dialog and download
the plugin, except for hidden plugins or plugins with small (less than 32x32
pixels) window where's no puzzle icon.

Comment 15

[André Dahlqvist]

serge, while I don't like the popup dialogs myself I do consider them a feature.
If a user doesn't like them popping up he can remove the null plugin and set
user_pref("plugin.display_plugin_downloader_dialog", false);. Below is an
updated patch that also makes the OK button the default button, so that ENTER
will do the same as pressing OK.

Comment 16

[André Dahlqvist]

Attachment: Patch that allows closing the dialog with ESC and using ENTER to get the plugin.

I tested this patch on top of a CVS trunk build, and it works as expected.

Comment 17

[av (gone)]

I tend to agree with André. I think we have some other bugs which cover the
issue of the desireness of this dialog and this issue is out of the scope of
this bug. As to adding ESC key functionality and defaulting the OK button, I
vote for this with both hands. This is more or less standard paradigm for dialog
boxes and I think this kind of behaviour is expected.

Comment 18

[serge (gone)]

Comment on attachment 74126 [details] [diff] [review]
Patch that allows closing the dialog with ESC and using ENTER to get the plugin.

ageed, r=serge

Comment 19

[André Dahlqvist]

Can I get a sr of this patch and get it checked in?

Comment 20

[Boris Zbarsky [:bzbarsky]]

André, you need to mail a super-reviewer (I suggest [e-mail] for
this bug) and cc [e-mail].  See
http://mozilla.org/hacking/reviewers.html for the full description of the process...

Comment 21

[Christopher Blizzard (:blizzard)]

Comment on attachment 74126 [details] [diff] [review]
Patch that allows closing the dialog with ESC and using ENTER to get the plugin.

sr=blizzard

Comment 22

[Boris Zbarsky [:bzbarsky]]

I have mailed drivers for approval for trunk.

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 74126 [details] [diff] [review]
Patch that allows closing the dialog with ESC and using ENTER to get the plugin.

a=asa (on behalf of drivers) for checkin to 1.1

Comment 24

[Boris Zbarsky [:bzbarsky]]

checked in on the trunk.

Comment 25

[shrirang khanzode]

works now, Andre, pls double check, thx!