Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla39
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(9 attachments, 1 obsolete attachment)

39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
39 bytes, text/x-review-board-request
h4writer
: review+
Details
Assignee

Description

4 years ago
Those have been on my todo list for a while now...
Assignee

Comment 1

4 years ago
/r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h;
/r/5843 - Bug 1146295: Factor out SIMD types initialization;
/r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper;
/r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace;
/r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass;
/r/5851 - Bug 1146295: Factor out SimdTypeDescr::call.
/r/5853 - Bug 1146295: Remove unused FuncZero function;
/r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn;

Pull down these commits:

hg pull review -r af3177adf567b8fead84300bf5672771a346a23b
Attachment #8581552 - Flags: review?(hv1989)
Assignee

Comment 3

4 years ago
Oops, apparently tbpl doesn't like funcTemplate<::name>();
Maybe with a space...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=836a7dea3134
Assignee

Comment 4

4 years ago
Comment on attachment 8581552 [details]
MozReview Request: bz://1146295/bbouvier

/r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h;
/r/5843 - Bug 1146295: Factor out SIMD types initialization;
/r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper;
/r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace;
/r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass;
/r/5851 - Bug 1146295: Factor out SimdTypeDescr::call.
/r/5853 - Bug 1146295: Remove unused FuncZero function;
/r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn;
/r/5963 - Bug 1146295: Make some arguments facultative in splat/with functions;

Pull down these commits:

hg pull review -r 6603f4c79e8afb2e40e541b31f88ea9e94fbeacf
https://reviewboard.mozilla.org/r/5855/#review4999

Can you give some more context why this change is needed? What is wrong with the old naming?
https://reviewboard.mozilla.org/r/5851/#review4995

::: js/src/builtin/SIMD.cpp
(Diff revision 2)
> +FillLanes(JSContext *cx, MutableHandle<TypedObject*> result, const CallArgs &args)
> +{
> +    typedef typename T::Elem Elem;
> +    Handle<TypedObject*> handleResult(result);

Shouldn't 'result' already be a Handle<TypedObject *> instead of a MutableHandle. If I understand this code correctly it doesn't change the result object to another object...
Assignee

Comment 13

4 years ago
Comment on attachment 8581552 [details]
MozReview Request: bz://1146295/bbouvier

/r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h; r=h4writer
/r/5843 - Bug 1146295: Factor out SIMD types initialization; r=h4writer
/r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper; r=h4writer
/r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace;
/r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass; r=h4writer
/r/5851 - Bug 1146295: Factor out SimdTypeDescr::call.
/r/5853 - Bug 1146295: Remove unused FuncZero function; r=h4writer
/r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn;
/r/5963 - Bug 1146295: Make some arguments facultative in splat/with functions; r=h4writer

Pull down these commits:

hg pull review -r 324b121cbd75111774f9e7ec3371686f15e3ab70
Assignee

Comment 15

4 years ago
https://reviewboard.mozilla.org/r/5855/#review5211

Just personal taste: it seems weird that SimdTypeDescr::TYPE_FLOAT32 (Scalar) actually means SimdTypeDescr::Float32x4. What do you think?
https://reviewboard.mozilla.org/r/5847/#review5219

Ship It!

::: js/src/builtin/SIMD.cpp
(Diff revision 2)
> -namespace js {

Please use "anonymous namespace"
Comment on attachment 8581552 [details]
MozReview Request: bz://1146295/bbouvier

https://reviewboard.mozilla.org/r/5839/#review5221

Ship It!
Attachment #8581552 - Flags: review?(hv1989) → review+
Assignee

Comment 22

4 years ago
Attachment #8581552 - Attachment is obsolete: true
Attachment #8619839 - Flags: review+
Attachment #8619840 - Flags: review+
Attachment #8619841 - Flags: review+
Attachment #8619842 - Flags: review+
Attachment #8619843 - Flags: review+
Attachment #8619844 - Flags: review+
Attachment #8619845 - Flags: review+
Attachment #8619846 - Flags: review+
Attachment #8619847 - Flags: review+
You need to log in before you can comment on or make changes to this bug.