Closed
Bug 1146295
Opened 8 years ago
Closed 8 years ago
SIMD: a few cleanups
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(9 files, 1 obsolete file)
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
h4writer
:
review+
|
Details |
Those have been on my todo list for a while now...
Assignee | ||
Comment 1•8 years ago
|
||
/r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h; /r/5843 - Bug 1146295: Factor out SIMD types initialization; /r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper; /r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace; /r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass; /r/5851 - Bug 1146295: Factor out SimdTypeDescr::call. /r/5853 - Bug 1146295: Remove unused FuncZero function; /r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn; Pull down these commits: hg pull review -r af3177adf567b8fead84300bf5672771a346a23b
Attachment #8581552 -
Flags: review?(hv1989)
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=286ece5aa7ca
Assignee | ||
Comment 3•8 years ago
|
||
Oops, apparently tbpl doesn't like funcTemplate<::name>(); Maybe with a space... https://treeherder.mozilla.org/#/jobs?repo=try&revision=836a7dea3134
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8581552 [details] MozReview Request: bz://1146295/bbouvier /r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h; /r/5843 - Bug 1146295: Factor out SIMD types initialization; /r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper; /r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace; /r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass; /r/5851 - Bug 1146295: Factor out SimdTypeDescr::call. /r/5853 - Bug 1146295: Remove unused FuncZero function; /r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn; /r/5963 - Bug 1146295: Make some arguments facultative in splat/with functions; Pull down these commits: hg pull review -r 6603f4c79e8afb2e40e541b31f88ea9e94fbeacf
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/5963/#review5001
Comment 6•8 years ago
|
||
https://reviewboard.mozilla.org/r/5855/#review4999 Can you give some more context why this change is needed? What is wrong with the old naming?
Comment 7•8 years ago
|
||
https://reviewboard.mozilla.org/r/5853/#review4997
Comment 8•8 years ago
|
||
https://reviewboard.mozilla.org/r/5849/#review4993
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/5843/#review4989
Comment 10•8 years ago
|
||
https://reviewboard.mozilla.org/r/5841/#review4987
Comment 11•8 years ago
|
||
https://reviewboard.mozilla.org/r/5851/#review4995 ::: js/src/builtin/SIMD.cpp (Diff revision 2) > +FillLanes(JSContext *cx, MutableHandle<TypedObject*> result, const CallArgs &args) > +{ > + typedef typename T::Elem Elem; > + Handle<TypedObject*> handleResult(result); Shouldn't 'result' already be a Handle<TypedObject *> instead of a MutableHandle. If I understand this code correctly it doesn't change the result object to another object...
Comment 12•8 years ago
|
||
https://reviewboard.mozilla.org/r/5845/#review4991
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8581552 [details] MozReview Request: bz://1146295/bbouvier /r/5841 - Bug 1146295: Remove "flags" macro argument in SIMD.h; r=h4writer /r/5843 - Bug 1146295: Factor out SIMD types initialization; r=h4writer /r/5845 - Bug 1146295: Factor out SIMD type's methods with their definitions class helper; r=h4writer /r/5847 - Bug 1146295: SIMD types' definition helpers have nothing to do in the ::js namespace; /r/5849 - Bug 1146295: Inline the last part of CreateAndBindSimdType into CreateAndBindSimdClass; r=h4writer /r/5851 - Bug 1146295: Factor out SimdTypeDescr::call. /r/5853 - Bug 1146295: Remove unused FuncZero function; r=h4writer /r/5855 - Bug 1146295: Rename SimdTypeDescr::TYPE_SCALAR into SimdTypeDescr::TypeXn; /r/5963 - Bug 1146295: Make some arguments facultative in splat/with functions; r=h4writer Pull down these commits: hg pull review -r 324b121cbd75111774f9e7ec3371686f15e3ab70
Comment 14•8 years ago
|
||
https://reviewboard.mozilla.org/r/5855/#review5215 Ship It!
Assignee | ||
Comment 15•8 years ago
|
||
https://reviewboard.mozilla.org/r/5855/#review5211 Just personal taste: it seems weird that SimdTypeDescr::TYPE_FLOAT32 (Scalar) actually means SimdTypeDescr::Float32x4. What do you think?
Comment 16•8 years ago
|
||
https://reviewboard.mozilla.org/r/5851/#review5217 Ship It!
Comment 17•8 years ago
|
||
https://reviewboard.mozilla.org/r/5847/#review5219 Ship It! ::: js/src/builtin/SIMD.cpp (Diff revision 2) > -namespace js { Please use "anonymous namespace"
Comment 18•8 years ago
|
||
Comment on attachment 8581552 [details] MozReview Request: bz://1146295/bbouvier https://reviewboard.mozilla.org/r/5839/#review5221 Ship It!
Attachment #8581552 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 19•8 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=e78ddf91b230
Assignee | ||
Comment 20•8 years ago
|
||
Put aside the GC failures caused by a previous push, it's green, so i'll consider it green (at this point, this might be madness). remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8db04357fe91 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf1f3c86e45d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf48b5413dbc remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/742a3be51627 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d12be5ebcad5 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b3d979d974a remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/701309c14003 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/57bd743ef57b remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/98cf094bbc05
Comment 21•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8db04357fe91 https://hg.mozilla.org/mozilla-central/rev/bf1f3c86e45d https://hg.mozilla.org/mozilla-central/rev/cf48b5413dbc https://hg.mozilla.org/mozilla-central/rev/742a3be51627 https://hg.mozilla.org/mozilla-central/rev/d12be5ebcad5 https://hg.mozilla.org/mozilla-central/rev/2b3d979d974a https://hg.mozilla.org/mozilla-central/rev/701309c14003 https://hg.mozilla.org/mozilla-central/rev/57bd743ef57b https://hg.mozilla.org/mozilla-central/rev/98cf094bbc05
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Assignee | ||
Comment 22•7 years ago
|
||
Attachment #8581552 -
Attachment is obsolete: true
Attachment #8619839 -
Flags: review+
Attachment #8619840 -
Flags: review+
Attachment #8619841 -
Flags: review+
Attachment #8619842 -
Flags: review+
Attachment #8619843 -
Flags: review+
Attachment #8619844 -
Flags: review+
Attachment #8619845 -
Flags: review+
Attachment #8619846 -
Flags: review+
Attachment #8619847 -
Flags: review+
Assignee | ||
Comment 23•7 years ago
|
||
Assignee | ||
Comment 24•7 years ago
|
||
Assignee | ||
Comment 25•7 years ago
|
||
Assignee | ||
Comment 26•7 years ago
|
||
Assignee | ||
Comment 27•7 years ago
|
||
Assignee | ||
Comment 28•7 years ago
|
||
Assignee | ||
Comment 29•7 years ago
|
||
Assignee | ||
Comment 30•7 years ago
|
||
Assignee | ||
Comment 31•7 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•