Change tr default search to Yandex for Firefox 37

RESOLVED FIXED

Status

Mozilla Localizations
tr / Turkish
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mconnor, Assigned: mconnor)

Tracking

unspecified

Firefox Tracking Flags

(firefox36 unaffected, firefox37+ fixed, firefox38 fixed, firefox39 fixed, relnote-firefox 37+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8581623 [details] [diff] [review]
yandexDefaultTR

As discussed in email. Confidential until this is publicly announced.
Attachment #8581623 - Flags: review?(selim)
(Assignee)

Updated

3 years ago
Assignee: erkan → mconnor

Comment 1

3 years ago
Comment on attachment 8581623 [details] [diff] [review]
yandexDefaultTR

Just making sure:
Do we need to add the line
browser.search.order.2=Google
to mobile/chrome/region.properties so we still have Google as the second option just like the desktop version?
Flags: needinfo?(mconnor)
(Assignee)

Comment 2

3 years ago
There's no formal requirement to do so.  Your call if that's the right thing for your users.  Feels like it would be, but I'm not convinced.
Flags: needinfo?(mconnor)
Tracking for 37. We're going to take this change on Wed, Mar 25 - the earlier the better.
status-firefox36: --- → unaffected
status-firefox37: --- → affected
status-firefox38: --- → affected
status-firefox39: --- → affected
tracking-firefox37: --- → +

Comment 4

3 years ago
Comment on attachment 8581623 [details] [diff] [review]
yandexDefaultTR

Review of attachment 8581623 [details] [diff] [review]:
-----------------------------------------------------------------

Mike, we've quickly discussed this among our core team members, and the unanimous decision was to keep Google as an alternative.
Could you please update the patch according to this (or should I)?
Attachment #8581623 - Flags: review?(selim) → review-
(Assignee)

Comment 5

3 years ago
Ok. (To be clear, it will be an alternative regardless, but this will default it to second place.)
(In reply to Mike Connor [:mconnor] from comment #5)
> Ok. (To be clear, it will be an alternative regardless, but this will
> default it to second place.)

Just to clarify in case there are any doubts:
* The list of available searchplugins comes from list.txt
* Searchplugins are displayed in alphabetical order (ShortName). This order can be overridden by browser.search.order.*

The current patch will display
Yandex
Google
Twitter
Wikipedia

A patch with "browser.search.order.2 = Google" will currently have the same practical result.

Updated

3 years ago
Attachment #8581623 - Flags: review- → review+

Comment 7

3 years ago
Thanks, Francesco. That was my mistake, then.
I've just modified the review flag.

Comment 8

3 years ago
I'm not sure we have clearance to actually land this yet. We should wait for mconnor's OK.
(In reply to Axel Hecht [:Pike] from comment #8)
> I'm not sure we have clearance to actually land this yet. We should wait for
> mconnor's OK.

I don't think either (waiting for confirmation from Yandex that we could put this in public),
I assume this is safe to land?
https://blog.mozilla.org/press/2015/03/mozilla-makes-yandex-the-default-search-engine-for-firefox-in-turkey/

Note: don't land directly on l10n-central, but pull changesets from mozilla-aurora into l10n-central (you won't need a merge). I can also do the actual landing if you want.
Flags: needinfo?(mconnor)
(Assignee)

Comment 11

3 years ago
Yes, please land this ASAP.
Flags: needinfo?(mconnor)
http://hg.mozilla.org/releases/l10n/mozilla-beta/tr/rev/b1c55920d4f4
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/b1c55920d4f4
http://hg.mozilla.org/l10n-central/tr/rev/b1c55920d4f4
ni Ben for comment on how we can most easily incorporate this change in the 37.0 Turkish build.
Group: mozilla-employee-confidential
Flags: needinfo?(bhearsum)

Comment 14

3 years ago
flod's still landing on l10n/release, and I'll do a sign-off on 37 with the yandex change in the next half-hour.
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #13)
> ni Ben for comment on how we can most easily incorporate this change in the
> 37.0 Turkish build.

Once the change is landed in the turkish mozilla-release l10n repo (http://hg.mozilla.org/releases/l10n/mozilla-release/tr/) I've got to go kick a bunch of stuff by hand.
Flags: needinfo?(bhearsum)
Also
http://hg.mozilla.org/releases/l10n/mozilla-release/tr/rev/b1c55920d4f4

Didn't realize that mozilla-beta was already merged in mozilla-release at this point.
The rebuilds are done now. There's still a couple of verification tests running, but all is looking good AFAICT. Might be a good idea for someone to manually check one of the builds though. Eg: http://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/37.0-candidates/build1/mac/tr/Firefox%2037.0.dmg

Comment 18

3 years ago
I've just checked the win32 version and it looked fine to me.
relnoted as "Yandex now default search provider for the Turkish locale"
relnote-firefox: --- → 37+
I think this work is done and the bug can be resolved. Is there any reason to keep it open?
(Assignee)

Comment 21

3 years ago
We screwed up the Android bits. The codes are wrong, and wrongly implemented. Sigh.

I'll fix that shortly.
This bug is *sort of* fixed in 37. 

Mike - Can we resolve this as fixed in 37 and file a follow-up to fix the Android bits?
Flags: needinfo?(mconnor)
Blocks: 1154759
I filed bug 1154759 as a follow up for the Android bits. I'm resolving this as fixed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(mconnor)
Resolution: --- → FIXED
status-firefox37: affected → fixed
status-firefox38: affected → fixed
status-firefox39: affected → fixed
You need to log in before you can comment on or make changes to this bug.