Closed Bug 1146363 Opened 5 years ago Closed 5 years ago

Inline SIMD.int32x4.bool

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file, 2 obsolete files)

We can do so by using the identity SIMD.int32x4.bool(x) === SIMD.int32x4(!x - 1)
Attached patch bool.patch (obsolete) — Splinter Review
here we go, with a simplification on MNot::New function.
Attachment #8581635 - Flags: review?(sunfish)
Attached patch bool.patch (obsolete) — Splinter Review
With the new SM style
Attachment #8581635 - Attachment is obsolete: true
Attachment #8581635 - Flags: review?(sunfish)
Attachment #8589155 - Flags: review?(sunfish)
Attached patch bool.patchSplinter Review
(and with a patch that actually compiles...)
Attachment #8589155 - Attachment is obsolete: true
Attachment #8589155 - Flags: review?(sunfish)
Attachment #8589157 - Flags: review?(sunfish)
Comment on attachment 8589157 [details] [diff] [review]
bool.patch

Review of attachment 8589157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8589157 - Flags: review?(sunfish) → review+
https://hg.mozilla.org/mozilla-central/rev/05532af92277
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.