Closed Bug 1146363 Opened 9 years ago Closed 9 years ago

Inline SIMD.int32x4.bool

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file, 2 obsolete files)

bool.patch
9.83 KB, patch
sunfish
: review+
Details | Diff | Splinter Review 
We can do so by using the identity SIMD.int32x4.bool(x) === SIMD.int32x4(!x - 1)
Attached patch bool.patch (obsolete) — — Splinter Review 
here we go, with a simplification on MNot::New function.
Attachment #8581635 - Flags: review?(sunfish)
Attached patch bool.patch (obsolete) — — Splinter Review 
With the new SM style
Attachment #8581635 - Attachment is obsolete: true
Attachment #8581635 - Flags: review?(sunfish)
Attachment #8589155 - Flags: review?(sunfish)
Attached patch bool.patch — — Splinter Review 
(and with a patch that actually compiles...)
Attachment #8589155 - Attachment is obsolete: true
Attachment #8589155 - Flags: review?(sunfish)
Attachment #8589157 - Flags: review?(sunfish)
Comment on attachment 8589157 [details] [diff] [review]
bool.patch

Review of attachment 8589157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8589157 - Flags: review?(sunfish) → review+
https://hg.mozilla.org/mozilla-central/rev/05532af92277
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: