1146378 - jit_test.py harness is broken because it passes --ion-extra-checks to the shell but the shell does not understand that

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Lars T Hansen [:lth]]

The offending line comes from js/src/tests/lib/tests.py and appears to have been added by h4writer on 18 March 2015:

changeset:   234206:cdf93416b39a
user:        Hannes Verschore <[e-mail]>
date:        Wed Mar 18 10:08:39 2015 +0100
summary:     Bug 1139152 - IonMonkey: Add dynamic output type checks for LIRs that use redefine, r=jandem

diff --git a/js/src/tests/lib/tests.py b/js/src/tests/lib/tests.py
--- a/js/src/tests/lib/tests.py
+++ b/js/src/tests/lib/tests.py
@@ -10,17 +10,17 @@ from threading import Thread
 from results import TestOutput
 
 # When run on tbpl, we run each test multiple times with the following
 # arguments.
 TBPL_FLAGS = [
     [], # no flags, normal baseline and ion
     ['--ion-eager', '--ion-offthread-compile=off'], # implies --baseline-eager
     ['--ion-eager', '--ion-offthread-compile=off',
-     '--ion-check-range-analysis', '--no-sse3', '--no-threads'],
+     '--ion-check-range-analysis', '--ion-extra-checks', '--no-sse3', '--no-threads'],
     ['--baseline-eager'],
     ['--baseline-eager', '--no-fpu'],
     ['--no-baseline', '--no-ion'],
 ]
 
 def do_run_cmd(cmd):
     l = [None, None]
     th_run_cmd(cmd, l)

(May be a duplicate argument?)

Comment 1

[Lars T Hansen [:lth]]

Problem between chair and keyboard (running stale binary).