Closed
Bug 1146380
Opened 10 years ago
Closed 10 years ago
Firefox shouldn't be warning that Valence might make it run slowly
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file)
1.26 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
Bug 1071880 added a warning that is shown every time Firefox spends a lot of time in the compartment of an add-on. Valence should be excluded from this check because it's an official Firefox feature that only happens to be shipped as an add-on.
Furthermore, the code that implements this check treats the devtools loader as an add-on causeing the following error to appear in the browser console:
couldn't look up addon: fx-devtools nsBrowserGlue.js:571:0
Assignee | ||
Comment 1•10 years ago
|
||
This patch makes both the error and the warning go away.
Attachment #8581668 -
Flags: review?(blassey.bugs)
Updated•10 years ago
|
Attachment #8581668 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Backed out for a syntax error that was causing other pref reads to fail:
https://hg.mozilla.org/integration/fx-team/rev/9cee181014eb
Assignee | ||
Comment 4•10 years ago
|
||
Sorry about that! I could swear it was working fine when I tested it locally... *sigh*
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment 7•10 years ago
|
||
I have found the same error about making Firefox slow on :
User Agent Mozilla/5.0 (Windows NT 6.3; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID 20150323030203
Looks like its fixed on today's nightly build :
Build ID 20150629134017
User Agent Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0
Suggesting STATUS -> VERIFIED FIXED
[Bugday-20150701]
Not sure this is fixed. I saw a "would you like to disable Valence" prompt in the current nightly while using the browser toolbox.
(In reply to Gummi from comment #8)
> Not sure this is fixed. I saw a "would you like to disable Valence" prompt
> in the current nightly while using the browser toolbox.
I believe the remaining issue affects all SDK based add-ons, see bug 1191342.
See Also: → 1191342
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•