1146400 - [NFC] Remove mozNfc checks from NfcManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Krzysztof Mioduszewski[:tauzen]]

NfcManager is instantiated (via NfcCore) only when mozNfc API is available [0]. All the |if(mozNfc)| checks should be removed. 

[0] - https://github.com/mozilla-b2g/gaia/blob/d36676d0a02eb13f5eb358d5f2413a9bba103c40/apps/system/js/core.js#L39-L57

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] tauzen:Bug1146400_no_nfcdom_check > mozilla-b2g:master

Comment 2

[Krzysztof Mioduszewski[:tauzen]]

Comment on attachment 8581823 [details] [review]
[gaia] tauzen:Bug1146400_no_nfcdom_check > mozilla-b2g:master

Hi Greg, this is a small clean up patch. I've removed the unnecessary |mozNfc| checks, changed |dispatchEvent| to |this.publish| (from BaseModule). Additionally I've added comments which I forgot to add in Bug 1141490. Could you review this?

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8581823 [details] [review]
[gaia] tauzen:Bug1146400_no_nfcdom_check > mozilla-b2g:master

OK I've checked the patch it's good if the instance existing is guaranteed by the new system architecture.

Comment 4

[Krzysztof Mioduszewski[:tauzen]]

Yes, exactly. NfcManager is instantiated only if mozNfc API is available. This was actually pointed out by Alive [0]. Thank you very much for the review.

[0] - https://github.com/mozilla-b2g/gaia/pull/28962#discussion_r26729256

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#z0kVDb9qSbGDHgz5tGPzmw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[Krzysztof Mioduszewski[:tauzen]]

All tests on github are green [0], so let's try this once more.

[0] - https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4f78f12181b6fbe0e2490d865c7b1a0cdbbfa6c5

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d5cb256ca570c3ea206923f2f0e9c98185744d45